Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious arguments to PyErr_Format in unicodeobject.c #72640

Closed
zhangyangyu opened this issue Oct 16, 2016 · 3 comments
Closed

Spurious arguments to PyErr_Format in unicodeobject.c #72640

zhangyangyu opened this issue Oct 16, 2016 · 3 comments
Labels
3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@zhangyangyu
Copy link
Member

BPO 28454
Nosy @ncoghlan, @serhiy-storchaka, @zhangyangyu
Files
  • spurious_argument.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2016-10-16.22:42:56.317>
    created_at = <Date 2016-10-16.09:37:12.693>
    labels = ['interpreter-core', 'type-feature', '3.7']
    title = 'Spurious arguments to PyErr_Format in unicodeobject.c'
    updated_at = <Date 2016-10-16.22:42:56.315>
    user = 'https://github.com/zhangyangyu'

    bugs.python.org fields:

    activity = <Date 2016-10-16.22:42:56.315>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2016-10-16.22:42:56.317>
    closer = 'python-dev'
    components = ['Interpreter Core']
    creation = <Date 2016-10-16.09:37:12.693>
    creator = 'xiang.zhang'
    dependencies = []
    files = ['45114']
    hgrepos = []
    issue_num = 28454
    keywords = ['patch']
    message_count = 3.0
    messages = ['278757', '278758', '278784']
    nosy_count = 4.0
    nosy_names = ['ncoghlan', 'python-dev', 'serhiy.storchaka', 'xiang.zhang']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue28454'
    versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']

    @zhangyangyu
    Copy link
    Member Author

    In unicodeobject.c, there are some spurious arguments to PyErr_Format as the patch shows.

    @zhangyangyu zhangyangyu added 3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Oct 16, 2016
    @serhiy-storchaka
    Copy link
    Member

    LGTM.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 16, 2016

    New changeset cbe313cd1b55 by Benjamin Peterson in branch '3.5':
    remove extra PyErr_Format arguments (closes bpo-28454)
    https://hg.python.org/cpython/rev/cbe313cd1b55

    New changeset 738579b25d02 by Benjamin Peterson in branch '3.6':
    merge 3.5 (bpo-28454)
    https://hg.python.org/cpython/rev/738579b25d02

    New changeset b37db216c8e0 by Benjamin Peterson in branch 'default':
    merge 3.6 (bpo-28454)
    https://hg.python.org/cpython/rev/b37db216c8e0

    @python-dev python-dev mannequin closed this as completed Oct 16, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants