test_typing fails if asyncio unavailable

[vadmium]

BPO	28482
Nosy	@gvanrossum, @vadmium, @ilevkivskyi
Files	st-typing.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-10-21.23:20:19.267>
created_at = <Date 2016-10-20.04:23:14.940>
labels = ['3.7', 'type-bug', 'tests']
title = 'test_typing fails if asyncio unavailable'
updated_at = <Date 2016-10-22.00:23:06.544>
user = 'https://github.com/vadmium'

bugs.python.org fields:

activity = <Date 2016-10-22.00:23:06.544>
actor = 'martin.panter'
assignee = 'none'
closed = True
closed_date = <Date 2016-10-21.23:20:19.267>
closer = 'gvanrossum'
components = ['Tests']
creation = <Date 2016-10-20.04:23:14.940>
creator = 'martin.panter'
dependencies = []
files = ['45147']
hgrepos = []
issue_num = 28482
keywords = ['patch']
message_count = 8.0
messages = ['279013', '279035', '279160', '279164', '279166', '279169', '279170', '279173']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'python-dev', 'martin.panter', 'levkivskyi']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue28482'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']

[vadmium]

If you compile with “configure --without-threads”, various tests are already skipped because they rely on multithreading. However test_typing does not seem to handle this. It tries to import “asyncio”, which seems to depend on multithreading. I presume it is expected that asyncio requires multithreading, so perhaps the affected tests should be skipped in test_typing. Here is my attempt to skip them; please review.

[gvanrossum]

Can you submit this as a PR upstream, to github.com/python/typing?

[gvanrossum]

Ivan, if you want to apply it upstream be my guest!

[vadmium]

I will this to Git Hub when I get a chance to get set up, if that helps though :)

[ilevkivskyi]

Martin, I have opened a PR with your patch at python/typing
python/typing#304

[python-dev]

New changeset c3363f684a2d by Guido van Rossum in branch '3.5':
Issue bpo-28482: Skip a few test_typing tests if asyncio unavailable
https://hg.python.org/cpython/rev/c3363f684a2d

New changeset 8f3b4779afaf by Guido van Rossum in branch '3.6':
Issue bpo-28482: Skip a few test_typing tests if asyncio unavailable (3.5->3.6)
https://hg.python.org/cpython/rev/8f3b4779afaf

New changeset c5fb5ac84f1e by Guido van Rossum in branch 'default':
Issue bpo-28482: Skip a few test_typing tests if asyncio unavailable (3.6->3.7)
https://hg.python.org/cpython/rev/c5fb5ac84f1e

[gvanrossum]

Martin can you verify that this worked?

[vadmium]

Yep, working well. Thanks Guido & Ivan.