Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up known issues for AIX #73031

Closed
ericvw mannequin opened this issue Nov 30, 2016 · 12 comments
Closed

Clean up known issues for AIX #73031

ericvw mannequin opened this issue Nov 30, 2016 · 12 comments
Labels
3.7 (EOL) end of life docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@ericvw
Copy link
Mannequin

ericvw mannequin commented Nov 30, 2016

BPO 28845
Nosy @ericvw, @zware, @aixtools, @JulienPalard
PRs
  • bpo-28845: Clean up known issues for AIX #1670
  • Files
  • cleanup-readme-aix.patch: Clean up addressed known issues in README.AIX
  • cleanup-readme-aix2.patch: Revised original patch to only remove fixed/resolved referenced issues in README.AIX
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-05-24.19:29:59.910>
    created_at = <Date 2016-11-30.21:40:32.872>
    labels = ['type-feature', '3.7', 'docs']
    title = 'Clean up known issues for AIX'
    updated_at = <Date 2017-05-24.19:29:59.908>
    user = 'https://github.com/ericvw'

    bugs.python.org fields:

    activity = <Date 2017-05-24.19:29:59.908>
    actor = 'zach.ware'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2017-05-24.19:29:59.910>
    closer = 'zach.ware'
    components = ['Documentation']
    creation = <Date 2016-11-30.21:40:32.872>
    creator = 'ericvw'
    dependencies = []
    files = ['45712', '45713']
    hgrepos = []
    issue_num = 28845
    keywords = ['patch']
    message_count = 12.0
    messages = ['282105', '282109', '282112', '282114', '282420', '283044', '283103', '284550', '284559', '286218', '294380', '294382']
    nosy_count = 6.0
    nosy_names = ['ericvw', 'docs@python', 'zach.ware', 'David.Edelsohn', 'Michael.Felt', 'mdk']
    pr_nums = ['1670']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue28845'
    versions = ['Python 3.7']

    @ericvw
    Copy link
    Mannequin Author

    ericvw mannequin commented Nov 30, 2016

    This patch cleans up Misc/README.AIX for addressed known issues.

    Issues that have been marked fixed: bpo-11184, bpo-11185
    Issues resolved by new AIX version: bpo-1745108
    Issues resolved, but not yet marked fixed/closed: bpo-11188

    Additionally, it looks like bpo-10709 can be closed out as well.

    For bpo-1745108 and bpo-11188, I have verified they are addressed as of Python 3.5.2 on AIX 7.1 locally. The Python Buildbot is failing to build the curses module, but I believe Setup.local is needed for _curses and _curses_panel. I have gotten the aforementioned curses modules building locally and will figure out the appropriate channels getting Python's PPC64 AIX Buildbot updated independently.

    @ericvw ericvw mannequin added the 3.7 (EOL) end of life label Nov 30, 2016
    @ericvw ericvw mannequin assigned docspython Nov 30, 2016
    @ericvw ericvw mannequin added docs Documentation in the Doc dir type-feature A feature request or enhancement labels Nov 30, 2016
    @JulienPalard
    Copy link
    Member

    You're also removing:

    • Python has not been fully tested on AIX when compiled as a 64 bit
      application.

    I do not have an AIX at hand but can someone at least confirm that all test passes? Having a few issues fixed does not mean that Python has been fully tested.

    @ericvw
    Copy link
    Mannequin Author

    ericvw mannequin commented Nov 30, 2016

    Having a few issues fixed does not mean that Python has been fully tested.

    I uploaded cleanup-readme-aix2.patch, which revives back the line removed in question and only removes lines which reference issues.

    I just noticed the results of Python's tests on my AIX box differ from Python's PPC64 Buildbot. I'll investigate separately and submit patches for getting the tests to pass, which then it may be more appropriate to remove that line.

    @JulienPalard
    Copy link
    Member

    Look like bpo-1745108 has only be closed for being "outdated" (msg240919 ), it does not clearly mean that the bug does no longer exists.

    Have you been able to test the example in it?

    @ericvw
    Copy link
    Mannequin Author

    ericvw mannequin commented Dec 5, 2016

    I have been able to test the example without a segmentation fault.

    $ python3.5
    Python 3.5.2 (default, Nov 17 2016, 10:45:58) [C] on aix7
    Type "help", "copyright", "credits" or "license" for more information.
    >>> import curses
    >>> from curses import panel
    >>> def mkpanel(scr):
    ...         win = curses.newwin(8,8,1,1)
    ...         pan = panel.new_panel(win)
    ...
    >>> curses.wrapper(mkpanel)
    >>>

    @JulienPalard
    Copy link
    Member

    LGTM but no AIX to test it.

    @DavidEdelsohn
    Copy link
    Mannequin

    DavidEdelsohn mannequin commented Dec 13, 2016

    There is an AIX system in the Python buildbot farm. Why do you say no AIX to test?

    @aixtools
    Copy link
    Contributor

    aixtools commented Jan 3, 2017

    FWIW: just build python-2.7.13 using xlC - and ncurses-6.0 installed.

    root@x064:[/data/prj/python/python2-2.7.13]
    root@x064:[/data/prj/python/python2-2.7.13]./python
    Python 2.7.13 (default, Jan  3 2017, 11:16:59) [C] on aix5
    Type "help", "copyright", "credits" or "license" for more information.
    >>> import curses
    >>> from curses import panel
    >>> def mkpanel(scr):
    ...  win = curses.newwin(8,8,1,1)
    ...  pan = panel.new_panel(win)
    ...
    >>> curses.wrapper(mkpanel)
    >>>

    So, even for AIX 5.3 and Python2.7 this test seems solved. If the above is all that is needed!

    @aixtools
    Copy link
    Contributor

    aixtools commented Jan 3, 2017

    I request that you review bpo-27435 - in particular msg284557 - as I feel ctypes implementation for AIX is broken - at least as far as the supporting routines are concerned.

    When you know the "magic" one can call ctypes.CDLL() and it 'works'. ctypes.util.find_library() always returns None (maybe it works if a stack of GNU tools are also loaded, but not on a 'generic' AIX install)

    ctypes.LibraryLoader() is always successful (i.e., no Traceback) but I am (personally) unsure of the actual return value. It feels like a false positive.

    Thank you for your time and consideration!

    p.s. - a "fix/patch" is nearly accepted for Python3.7 (see bpo-26439) - needs more for the docs - however, I feel is is a great short-coming to limit this to versions that are yet to come!

    @ericvw
    Copy link
    Mannequin Author

    ericvw mannequin commented Jan 24, 2017

    I request that you review bpo-27435 - in particular msg284557 - as I feel ctypes implementation for AIX is broken - at least as far as the supporting routines are concerned.

    I believe this request is outside the scope of this particular issue.

    [...] AIX to test it.

    It appears there is an AIX system in Python's buildbot farm to validate the curses example. Is the next step have a core maintainer conduct the validation on an AIX system before this can move forward?

    @zware
    Copy link
    Member

    zware commented May 24, 2017

    New changeset 7c2f82d by Zachary Ware (Eric N. Vander Weele) in branch 'master':
    bpo-28845: Clean up known issues for AIX (GH-1670)
    7c2f82d

    @zware
    Copy link
    Member

    zware commented May 24, 2017

    Thanks for the patch! I'm going to decline backporting this; let's just focus on the future for this.

    @zware zware closed this as completed May 24, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life docs Documentation in the Doc dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants