liblzma is missing from pcbuild.sln

[segevfiner]

BPO	29191
Nosy	@pfmoore, @tjguk, @zware, @zooba, @jiamo, @Mariatta, @segevfiner
PRs	bpo-29191: Add liblzma.vcxproj to pcbuild.sln and other missing entries #1222 [3.6] bpo-29191: Add liblzma.vcxproj to pcbuild.sln and other missing entries #1244
Files	add-liblzma-to-pcbuild-sln.patch: Add liblzma to pcbuild.sln for default branch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2017-04-21.18:36:59.324>
created_at = <Date 2017-01-07.08:48:55.283>
labels = ['build', '3.7', 'OS-windows']
title = 'liblzma is missing from pcbuild.sln'
updated_at = <Date 2017-04-21.18:36:59.323>
user = 'https://github.com/segevfiner'

bugs.python.org fields:

activity = <Date 2017-04-21.18:36:59.323>
actor = 'Mariatta'
assignee = 'none'
closed = True
closed_date = <Date 2017-04-21.18:36:59.324>
closer = 'Mariatta'
components = ['Windows']
creation = <Date 2017-01-07.08:48:55.283>
creator = 'Segev Finer'
dependencies = []
files = ['46187']
hgrepos = []
issue_num = 29191
keywords = ['patch']
message_count = 8.0
messages = ['284902', '284920', '288484', '292003', '292016', '292066', '292072', '292073']
nosy_count = 7.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'Mo.Jia', 'Mariatta', 'Segev Finer']
pr_nums = ['1222', '1244']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue29191'
versions = ['Python 3.6', 'Python 3.7']

[segevfiner]

liblzma is missing from pcbuild.sln. This causes the build of _lzma to fail when building the solution and not using build.bat.

Attached is a patch that fixes this for the default branch. Note that it also includes some missing project configurations for the _asyncio module which Visual Studio will add every single time you open the solution.

A similar patch is simple enough to create for older versions/branches. Just Add->Existing Project liblzma.vcxproj and make sure to revert any lines in the sln which Visual Studio added that you don't want to commit. (Like VisualStudioVersion = ...)

[zooba]

LGTM. Though as you say, it's probably easiest for one of us to go through each branch and use VS to get it right. I think both of those projects were added from other operating systems, so updating the sln wouldn't be so easy.

I'll get to it at some point unless someone else does. The merging necessary is going to make using patch files difficult.

[jiamo]

I think let user add the liblzma project by hand is not good enough. While the build.bat don't have this problem. So they should work similar.

[zooba]

New changeset f60c9e5 by Steve Dower (Segev Finer) in branch 'master':
bpo-29191: Add liblzma.vcxproj to pcbuild.sln and other missing entries (bpo-1222)
f60c9e5

[segevfiner]

The PR was merged for Python 3.7. But this also affects older Python 3 versions that include liblzma/_lzma as far as I can tell. So I'm not closing this issue just yet, so that it will serve as a remainder, in case you do want to back port this.

Thanks for merging! :)

[zooba]

Yeah, merging into master is easy right now, but backports are still manual effort. It should only require 3.6, so I'll try to get to it today.

[Mariatta]

New changeset 1ccbe60 by Mariatta (Steve Dower) in branch '3.6':
bpo-29191: Add liblzma.vcxproj to pcbuild.sln and other missing entries (GH-1222) (GH-1244)
1ccbe60

[Mariatta]

Thanks everyone :) I merged the backport PR, so I'm closing this issue.

While backporting is still a manual effort, this utility script automates some part of it. https://github.com/python/core-workflow/tree/master/cherry_picker