Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncGenerator is missing from typing #73384

Closed
JelleZijlstra opened this issue Jan 7, 2017 · 9 comments
Closed

AsyncGenerator is missing from typing #73384

JelleZijlstra opened this issue Jan 7, 2017 · 9 comments
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@JelleZijlstra
Copy link
Member

BPO 29198
Nosy @gvanrossum, @berkerpeksag, @1st1, @ilevkivskyi, @JelleZijlstra
Files
  • asyncgenerator.patch: doc patch for typing.AsyncGenerator
  • asyncgenerator2.patch: fixes indentation (thanks Berker Peksag for reviewing), add version added tag
  • asyncgenerator3.patch: takes out the unrelated indentation change
  • typingindentation.patch: fixes indentation throughout typing.rst
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-02-04.06:30:47.592>
    created_at = <Date 2017-01-07.21:37:40.969>
    labels = ['3.7', 'type-feature', 'library']
    title = 'AsyncGenerator is missing from typing'
    updated_at = <Date 2017-02-04.07:00:38.664>
    user = 'https://github.com/JelleZijlstra'

    bugs.python.org fields:

    activity = <Date 2017-02-04.07:00:38.664>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-02-04.06:30:47.592>
    closer = 'berker.peksag'
    components = ['Library (Lib)']
    creation = <Date 2017-01-07.21:37:40.969>
    creator = 'JelleZijlstra'
    dependencies = []
    files = ['46202', '46203', '46219', '46220']
    hgrepos = []
    issue_num = 29198
    keywords = ['patch']
    message_count = 9.0
    messages = ['284937', '285754', '285757', '286914', '286915', '286916', '286917', '286919', '286920']
    nosy_count = 6.0
    nosy_names = ['gvanrossum', 'python-dev', 'berker.peksag', 'yselivanov', 'levkivskyi', 'JelleZijlstra']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue29198'
    versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']

    @JelleZijlstra
    Copy link
    Member Author

    PEP-525 async generators weren't added to typing.py, probably by oversight.

    I sent pull requests to typing and typeshed on GitHub to add an AsyncGenerator class and stub:

    However, typing docs are not in GitHub, so I'm attaching a doc patch here.

    @JelleZijlstra JelleZijlstra added 3.7 (EOL) end of life stdlib Python modules in the Lib dir labels Jan 7, 2017
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jan 18, 2017

    New changeset 87e8139420ed by Guido van Rossum in branch '3.5':
    Issue bpo-29198: add AsyncGenerator (Jelle Zijlstra)
    https://hg.python.org/cpython/rev/87e8139420ed

    New changeset 5b771c662c00 by Guido van Rossum in branch '3.6':
    Issue bpo-29198: add AsyncGenerator (Jelle Zijlstra) (3.5->3.6)
    https://hg.python.org/cpython/rev/5b771c662c00

    New changeset 07523532039d by Guido van Rossum in branch 'default':
    Issue bpo-29198: add AsyncGenerator (Jelle Zijlstra) (3.6->3.7)
    https://hg.python.org/cpython/rev/07523532039d

    @gvanrossum
    Copy link
    Member

    So the changes to typing.py have been committed. Can someone commit the right doc patches?

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 4, 2017

    New changeset fe29826af634 by Berker Peksag in branch '3.5':
    Issue bpo-29198: Document typing.AsyncGenerator
    https://hg.python.org/cpython/rev/fe29826af634

    New changeset b475b076cc1f by Berker Peksag in branch '3.6':
    Issue bpo-29198: Merge from 3.5
    https://hg.python.org/cpython/rev/b475b076cc1f

    New changeset 2b55b18bf151 by Berker Peksag in branch 'default':
    Issue bpo-29198: Merge from 3.6
    https://hg.python.org/cpython/rev/2b55b18bf151

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 4, 2017

    New changeset d7eb9526c4f4 by Berker Peksag in branch '3.5':
    Issue bpo-29198: Fix indentation and markup in typing.rst
    https://hg.python.org/cpython/rev/d7eb9526c4f4

    New changeset f49b6c35d1e3 by Berker Peksag in branch '3.6':
    Issue bpo-29198: Merge from 3.5
    https://hg.python.org/cpython/rev/f49b6c35d1e3

    New changeset 8a898cfd089a by Berker Peksag in branch 'default':
    Issue bpo-29198: Merge from 3.6
    https://hg.python.org/cpython/rev/8a898cfd089a

    @berkerpeksag
    Copy link
    Member

    Thanks for the patches, Jelle :)

    @berkerpeksag berkerpeksag added the type-feature A feature request or enhancement label Feb 4, 2017
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 4, 2017

    New changeset 7fd9559c9c97fcf0519ace33b9d76a81ae156523 by Berker Peksag in branch 'master':
    Issue bpo-29198: Document typing.AsyncGenerator
    7fd9559

    New changeset 34c0c17d5774524dae63d9e2e693ad4b97386bbe by Berker Peksag in branch 'master':
    Issue bpo-29198: Merge from 3.5
    34c0c17

    New changeset b6d785d86dbf4ea9b90da57f11da4fff1bb36c9d by Berker Peksag in branch 'master':
    Issue bpo-29198: Merge from 3.6
    b6d785d

    New changeset 2c6ff7794c1b1af545d8ff17f54acef41cab089e by Berker Peksag in branch 'master':
    Issue bpo-29198: Fix indentation and markup in typing.rst
    2c6ff77

    New changeset 9ea15544818e9186277efda1ce9da3a5e48ff1c7 by Berker Peksag in branch 'master':
    Issue bpo-29198: Merge from 3.5
    9ea1554

    New changeset bab4b9b5a4c16298b17a77cf2aec43320f296717 by Berker Peksag in branch 'master':
    Issue bpo-29198: Merge from 3.6
    bab4b9b

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 4, 2017

    New changeset 7fd9559c9c97fcf0519ace33b9d76a81ae156523 by Berker Peksag in branch '3.6':
    Issue bpo-29198: Document typing.AsyncGenerator
    7fd9559

    New changeset 34c0c17d5774524dae63d9e2e693ad4b97386bbe by Berker Peksag in branch '3.6':
    Issue bpo-29198: Merge from 3.5
    34c0c17

    New changeset 2c6ff7794c1b1af545d8ff17f54acef41cab089e by Berker Peksag in branch '3.6':
    Issue bpo-29198: Fix indentation and markup in typing.rst
    2c6ff77

    New changeset 9ea15544818e9186277efda1ce9da3a5e48ff1c7 by Berker Peksag in branch '3.6':
    Issue bpo-29198: Merge from 3.5
    9ea1554

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 4, 2017

    New changeset 7fd9559c9c97fcf0519ace33b9d76a81ae156523 by Berker Peksag in branch '3.5':
    Issue bpo-29198: Document typing.AsyncGenerator
    7fd9559

    New changeset 2c6ff7794c1b1af545d8ff17f54acef41cab089e by Berker Peksag in branch '3.5':
    Issue bpo-29198: Fix indentation and markup in typing.rst
    2c6ff77

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants