Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include thread_name_prefix in the concurrent.futures.ThreadPoolExecutor example 17.4.2.1 #73470

Open
jftuga mannequin opened this issue Jan 16, 2017 · 6 comments
Open
Assignees
Labels
3.7 (EOL) end of life 3.8 only security fixes docs Documentation in the Doc dir topic-multiprocessing type-feature A feature request or enhancement

Comments

@jftuga
Copy link
Mannequin

jftuga mannequin commented Jan 16, 2017

BPO 29284
Nosy @gpshead, @jftuga, @applio, @Mariatta, @csabella
Files
  • ThreadPoolExec_Example.py
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/Mariatta'
    closed_at = None
    created_at = <Date 2017-01-16.16:42:44.559>
    labels = ['3.8', 'type-feature', '3.7', 'docs']
    title = 'Include thread_name_prefix  in the concurrent.futures.ThreadPoolExecutor example 17.4.2.1'
    updated_at = <Date 2019-04-10.12:08:39.841>
    user = 'https://github.com/jftuga'

    bugs.python.org fields:

    activity = <Date 2019-04-10.12:08:39.841>
    actor = 'cheryl.sabella'
    assignee = 'Mariatta'
    closed = False
    closed_date = None
    closer = None
    components = ['Documentation']
    creation = <Date 2017-01-16.16:42:44.559>
    creator = 'jftuga'
    dependencies = []
    files = ['46377']
    hgrepos = []
    issue_num = 29284
    keywords = []
    message_count = 6.0
    messages = ['285572', '286006', '291605', '298733', '298748', '339854']
    nosy_count = 6.0
    nosy_names = ['gregory.p.smith', 'docs@python', 'jftuga', 'davin', 'Mariatta', 'cheryl.sabella']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = 'needs patch'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue29284'
    versions = ['Python 3.7', 'Python 3.8']

    @jftuga
    Copy link
    Mannequin Author

    jftuga mannequin commented Jan 16, 2017

    Please include how to use the thread_name_prefix method argument (new to Python 3.6) in the example: 17.4.2.1. ThreadPoolExecutor Example

    @jftuga jftuga mannequin assigned docspython Jan 16, 2017
    @jftuga jftuga mannequin added docs Documentation in the Doc dir type-feature A feature request or enhancement labels Jan 16, 2017
    @jftuga
    Copy link
    Mannequin Author

    jftuga mannequin commented Jan 22, 2017

    I have updated the Python 3.6 example for 17.4.2.1. ThreadPoolExecutor Example. Please see the attachment. On my system this is the output:

    thread name: loader_0
    thread name: loader_1
    thread name: loader_2
    thread name: loader_3
    thread name: loader_4
    'http://example.com/' page is 1270 bytes
    'http://www.foxnews.com/' page is 67351 bytes
    'http://www.cnn.com/' page is 137164 bytes
    'http://europe.wsj.com/' page is 914169 bytes
    'http://www.bbc.co.uk/' page is 229503 bytes

    Could you please consider adding this to the official documentation?

    @jftuga
    Copy link
    Mannequin Author

    jftuga mannequin commented Apr 13, 2017

    @jftuga
    Copy link
    Mannequin Author

    jftuga mannequin commented Jul 20, 2017

    Bump

    @csabella
    Copy link
    Contributor

    Hi John,

    Would you be able to make a GitHub pull request for your change? Since CPython development has moved to GitHub, you may have a better chance of a review with a PR.

    @csabella
    Copy link
    Contributor

    This seems like a reasonable request. A description of thread_name_prefix should probably also be added to the body of the class description instead of just in the versionadded directive.

    Assigning to @Mariatta for the sprints.

    Nosying @gregory.p.smith as he added the parameter in bpo-27664.

    @csabella csabella added 3.7 (EOL) end of life 3.8 only security fixes labels Apr 10, 2019
    @csabella csabella assigned Mariatta and unassigned docspython Apr 10, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes docs Documentation in the Doc dir topic-multiprocessing type-feature A feature request or enhancement
    Projects
    Status: No status
    Status: No status
    Development

    No branches or pull requests

    3 participants