Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncio.async deprecation warning is missing stacklevel=2 #73500

Closed
bitdancer opened this issue Jan 18, 2017 · 8 comments
Closed

asyncio.async deprecation warning is missing stacklevel=2 #73500

bitdancer opened this issue Jan 18, 2017 · 8 comments
Labels
3.7 (EOL) end of life topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@bitdancer
Copy link
Member

BPO 29314
Nosy @gvanrossum, @bitdancer, @methane, @1st1, @Mariatta
Files
  • issue29314.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-02-07.06:08:08.744>
    created_at = <Date 2017-01-18.20:07:47.749>
    labels = ['type-bug', '3.7', 'expert-asyncio']
    title = 'asyncio.async deprecation warning is missing stacklevel=2'
    updated_at = <Date 2017-02-07.07:00:29.161>
    user = 'https://github.com/bitdancer'

    bugs.python.org fields:

    activity = <Date 2017-02-07.07:00:29.161>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-02-07.06:08:08.744>
    closer = 'Mariatta'
    components = ['asyncio']
    creation = <Date 2017-01-18.20:07:47.749>
    creator = 'r.david.murray'
    dependencies = []
    files = ['46369']
    hgrepos = []
    issue_num = 29314
    keywords = ['patch']
    message_count = 8.0
    messages = ['285750', '285941', '286043', '287196', '287197', '287200', '287201', '287202']
    nosy_count = 6.0
    nosy_names = ['gvanrossum', 'r.david.murray', 'methane', 'python-dev', 'yselivanov', 'Mariatta']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue29314'
    versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']

    @bitdancer
    Copy link
    Member Author

    Title pretty much says it all. The warning isn't very helpful currently, since it just reports the line in tasks.py where the deprecation warning is generated.

    @bitdancer bitdancer added 3.7 (EOL) end of life topic-asyncio type-bug An unexpected behavior, bug, or error labels Jan 18, 2017
    @Mariatta
    Copy link
    Member

    Attached patch adds stacklevel=2 to the deprecation warning.

    @methane
    Copy link
    Member

    methane commented Jan 23, 2017

    LGTM.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 7, 2017

    New changeset 0f5161f865d7 by Mariatta Wijaya in branch '3.5':
    Issue bpo-29314: Set the stacklevel to two in asyncio.async() Deprecation Warning
    https://hg.python.org/cpython/rev/0f5161f865d7

    New changeset 6dbe9051cdec by Mariatta Wijaya in branch '3.6':
    Issue bpo-29314: Merge with 3.5
    https://hg.python.org/cpython/rev/6dbe9051cdec

    New changeset 9f16900bebaa by Mariatta Wijaya in branch 'default':
    Issue bpo-29314: Merge with 3.6
    https://hg.python.org/cpython/rev/9f16900bebaa

    @Mariatta
    Copy link
    Member

    Mariatta commented Feb 7, 2017

    Thanks all :)

    @Mariatta Mariatta closed this as completed Feb 7, 2017
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 7, 2017

    New changeset 00c949c7c3a3eed27a0b320d320097f630eb8fc5 by Mariatta Wijaya in branch 'master':
    Issue bpo-29314: Set the stacklevel to two in asyncio.async() Deprecation Warning
    00c949c

    New changeset 22fce50aa151160540326001ace1e0826f6323a1 by Mariatta Wijaya in branch 'master':
    Issue bpo-29314: Merge with 3.5
    22fce50

    New changeset 2ef05ee4f1c721732918c8839b0b3ac5f1c807a7 by Mariatta Wijaya in branch 'master':
    Issue bpo-29314: Merge with 3.6
    2ef05ee

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 7, 2017

    New changeset 00c949c7c3a3eed27a0b320d320097f630eb8fc5 by Mariatta Wijaya in branch '3.6':
    Issue bpo-29314: Set the stacklevel to two in asyncio.async() Deprecation Warning
    00c949c

    New changeset 22fce50aa151160540326001ace1e0826f6323a1 by Mariatta Wijaya in branch '3.6':
    Issue bpo-29314: Merge with 3.5
    22fce50

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 7, 2017

    New changeset 00c949c7c3a3eed27a0b320d320097f630eb8fc5 by Mariatta Wijaya in branch '3.5':
    Issue bpo-29314: Set the stacklevel to two in asyncio.async() Deprecation Warning
    00c949c

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life topic-asyncio type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants