Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant ensure_future() calls in factorial example #73593

Closed
berkerpeksag opened this issue Feb 1, 2017 · 7 comments
Closed

Remove redundant ensure_future() calls in factorial example #73593

berkerpeksag opened this issue Feb 1, 2017 · 7 comments
Labels
3.7 (EOL) end of life docs Documentation in the Doc dir topic-asyncio type-feature A feature request or enhancement

Comments

@berkerpeksag
Copy link
Member

BPO 29407
Nosy @gvanrossum, @berkerpeksag, @1st1
Files
  • ensure_future.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-02-01.19:35:06.449>
    created_at = <Date 2017-02-01.01:09:07.058>
    labels = ['type-feature', '3.7', 'docs', 'expert-asyncio']
    title = 'Remove redundant ensure_future() calls in factorial example'
    updated_at = <Date 2017-02-01.20:00:30.689>
    user = 'https://github.com/berkerpeksag'

    bugs.python.org fields:

    activity = <Date 2017-02-01.20:00:30.689>
    actor = 'python-dev'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2017-02-01.19:35:06.449>
    closer = 'berker.peksag'
    components = ['Documentation', 'asyncio']
    creation = <Date 2017-02-01.01:09:07.058>
    creator = 'berker.peksag'
    dependencies = []
    files = ['46471']
    hgrepos = []
    issue_num = 29407
    keywords = ['patch']
    message_count = 7.0
    messages = ['286576', '286667', '286680', '286681', '286685', '286686', '286687']
    nosy_count = 5.0
    nosy_names = ['gvanrossum', 'docs@python', 'python-dev', 'berker.peksag', 'yselivanov']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue29407'
    versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']

    @berkerpeksag
    Copy link
    Member Author

    Unless I'm missing something, ensure_future() calls at https://docs.python.org/3.6/library/asyncio-task.html#example-parallel-execution-of-tasks are redundant and can be removed.

    Off-topic: Can we use the async/await keywords in asyncio docs now?

    @berkerpeksag berkerpeksag added the 3.7 (EOL) end of life label Feb 1, 2017
    @berkerpeksag berkerpeksag added docs Documentation in the Doc dir topic-asyncio type-feature A feature request or enhancement labels Feb 1, 2017
    @gvanrossum
    Copy link
    Member

    LGTM, and should be committed to 3.5 and merged upwards from there.

    And yes, it's time for the asyncio docs to converge on async/await everywhere, making yield from a footnoot to history.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 1, 2017

    New changeset e4f6874abda6 by Berker Peksag in branch '3.5':
    Issue bpo-29407: Remove redundant ensure_future() calls in factorial example
    https://hg.python.org/cpython/rev/e4f6874abda6

    New changeset 7196ab02b7ce by Berker Peksag in branch '3.6':
    Issue bpo-29407: Merge from 3.5
    https://hg.python.org/cpython/rev/7196ab02b7ce

    New changeset 0990a071751f by Berker Peksag in branch 'default':
    Issue bpo-29407: Merge from 3.6
    https://hg.python.org/cpython/rev/0990a071751f

    @berkerpeksag
    Copy link
    Member Author

    Thanks for the review, Guido.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 9, 2022

    New changeset 94aa4efdf0196de9f99b6f1bd68322939d8d6974 by Berker Peksag in branch '3.6':
    Issue bpo-29407: Remove redundant ensure_future() calls in factorial example
    94aa4ef

    New changeset 96104636fa5bd3054367d4667d86d43690c24293 by Berker Peksag in branch '3.6':
    Issue bpo-29407: Merge from 3.5
    9610463

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 9, 2022

    New changeset 94aa4efdf0196de9f99b6f1bd68322939d8d6974 by Berker Peksag in branch '3.5':
    Issue bpo-29407: Remove redundant ensure_future() calls in factorial example
    94aa4ef

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 9, 2022

    New changeset 94aa4efdf0196de9f99b6f1bd68322939d8d6974 by Berker Peksag in branch 'master':
    Issue bpo-29407: Remove redundant ensure_future() calls in factorial example
    94aa4ef

    New changeset 96104636fa5bd3054367d4667d86d43690c24293 by Berker Peksag in branch 'master':
    Issue bpo-29407: Merge from 3.5
    9610463

    New changeset 6b569a0de28e3c341837030d6aa739422d315a6f by Berker Peksag in branch 'master':
    Issue bpo-29407: Merge from 3.6
    6b569a0

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life docs Documentation in the Doc dir topic-asyncio type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants