xattr functions aren't in os.supports_fd, os.supports_follow_symlinks

[osandov]

BPO	29450
Nosy	@benjaminp, @osandov, @ZackerySpytz
PRs	gh-73636: Include xattr functions in os.supports_{fd,follow_symlinks} #18653
Files	xattrsupports.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2017-02-05.09:44:20.580>
labels = ['extension-modules', 'type-feature', '3.7']
title = "xattr functions aren't in os.supports_fd, os.supports_follow_symlinks"
updated_at = <Date 2020-02-25.06:51:56.896>
user = 'https://github.com/osandov'

bugs.python.org fields:

activity = <Date 2020-02-25.06:51:56.896>
actor = 'ZackerySpytz'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules']
creation = <Date 2017-02-05.09:44:20.580>
creator = 'osandov'
dependencies = []
files = ['46522']
hgrepos = []
issue_num = 29450
keywords = ['patch']
message_count = 1.0
messages = ['287042']
nosy_count = 3.0
nosy_names = ['benjamin.peterson', 'osandov', 'ZackerySpytz']
pr_nums = ['18653']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue29450'
versions = ['Python 3.7']

[osandov]

{get,list,remove,set}xattr all support fds and follow_symlinks, but they are not in the os.supports_fds and os.supports_follow_symlinks sets. The attached patch adds them. There are no HAVE_* features for the f and l variants of these syscalls since it's an all-or-nothing thing, so we always add them if the functions are defined.

[serhiy-storchaka]

Since these function always support these features, there should not be need in runtime checks. Adding them in the os.supports_fds and os.supports_follow_symlinks sets will have no practical effect.

As another example, os.fwalk() supports follow_symlinks,but is not included in os.supports_follow_symlinks.

[serhiy-storchaka]

Closed, as this change is not necessary.