Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SlotWrapperType to WrapperDescriptorType #74136

Closed
DimitrisJim mannequin opened this issue Mar 30, 2017 · 5 comments
Closed

Rename SlotWrapperType to WrapperDescriptorType #74136

DimitrisJim mannequin opened this issue Mar 30, 2017 · 5 comments
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@DimitrisJim
Copy link
Mannequin

DimitrisJim mannequin commented Mar 30, 2017

BPO 29950
Nosy @berkerpeksag, @DimitrisJim, @corona10
PRs
  • bpo-29950: Rename SlotWrapperType to WrapperDescriptorType #1166
  • bpo-29950: Rename SlotWrapperType to WrapperDescriptorType #926
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-05-13.16:25:07.210>
    created_at = <Date 2017-03-30.22:32:35.653>
    labels = ['3.7', 'type-bug', 'library']
    title = 'Rename SlotWrapperType to WrapperDescriptorType'
    updated_at = <Date 2017-05-13.16:25:07.209>
    user = 'https://github.com/DimitrisJim'

    bugs.python.org fields:

    activity = <Date 2017-05-13.16:25:07.209>
    actor = 'Jim Fasarakis-Hilliard'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-05-13.16:25:07.210>
    closer = 'Jim Fasarakis-Hilliard'
    components = ['Library (Lib)']
    creation = <Date 2017-03-30.22:32:35.653>
    creator = 'Jim Fasarakis-Hilliard'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 29950
    keywords = []
    message_count = 5.0
    messages = ['290883', '291816', '291830', '292065', '292275']
    nosy_count = 3.0
    nosy_names = ['berker.peksag', 'Jim Fasarakis-Hilliard', 'corona10']
    pr_nums = ['1166', '926']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue29950'
    versions = ['Python 3.7']

    @DimitrisJim
    Copy link
    Mannequin Author

    DimitrisJim mannequin commented Mar 30, 2017

    The name SlotWrapperType was added in bpo-29377 but it added the type based on the repr of the object instead of it's type as type(object.__init__) results in.

    I proposed this be named to WrapperDescriptorType to avoid and any unecessary confusion down the line.

    @DimitrisJim DimitrisJim mannequin added 3.7 (EOL) end of life stdlib Python modules in the Lib dir labels Mar 30, 2017
    @corona10
    Copy link
    Member

    I am a newcomer who is interesting with contributing CPython project.
    This issue looks easy to solve.
    Can I proceed this issue?

    @DimitrisJim
    Copy link
    Mannequin Author

    DimitrisJim mannequin commented Apr 18, 2017

    Dong-hee, I apologize. I had made a silly mistake in the title of my PR and, as such, it didn't appear here on bpo.

    Thanks for the PR, though! :-)

    @DimitrisJim
    Copy link
    Mannequin Author

    DimitrisJim mannequin commented Apr 21, 2017

    This was added in python/typing just a couple of days ago, so I'm bumping to maybe get the PR to python/cpython merged too.

    @berkerpeksag
    Copy link
    Member

    Merged in 08c1601.

    Thanks!

    @berkerpeksag berkerpeksag added the type-bug An unexpected behavior, bug, or error label Apr 25, 2017
    @DimitrisJim DimitrisJim mannequin closed this as completed May 13, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants