Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urllib.parse clarify what ' ' in schemes mean #74162

Closed
orsenthil opened this issue Apr 4, 2017 · 5 comments
Closed

urllib.parse clarify what ' ' in schemes mean #74162

orsenthil opened this issue Apr 4, 2017 · 5 comments
Assignees
Labels
3.7 (EOL) end of life type-bug An unexpected behavior, bug, or error

Comments

@orsenthil
Copy link
Member

BPO 29976
Nosy @orsenthil
PRs
  • bpo-29976: urllib.parse clarify '' in scheme values. #984
  • bpo-29976: urllib.parse clarify '' in scheme values. (GH-984) #1692
  • bpo-29976: urllib.parse clarify '' in scheme values. (GH-984) #1693
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/orsenthil'
    closed_at = <Date 2017-05-21.05:25:37.738>
    created_at = <Date 2017-04-04.04:54:17.749>
    labels = ['type-bug', '3.7']
    title = "urllib.parse clarify what ' ' in schemes mean"
    updated_at = <Date 2017-05-21.06:23:05.429>
    user = 'https://github.com/orsenthil'

    bugs.python.org fields:

    activity = <Date 2017-05-21.06:23:05.429>
    actor = 'orsenthil'
    assignee = 'orsenthil'
    closed = True
    closed_date = <Date 2017-05-21.05:25:37.738>
    closer = 'orsenthil'
    components = []
    creation = <Date 2017-04-04.04:54:17.749>
    creator = 'orsenthil'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 29976
    keywords = []
    message_count = 5.0
    messages = ['291100', '291102', '293909', '294076', '294077']
    nosy_count = 1.0
    nosy_names = ['orsenthil']
    pr_nums = ['984', '1692', '1693']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue29976'
    versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']

    @orsenthil
    Copy link
    Member Author

    urllib.parse has the following information in this module.

    # A classification of schemes ('' means apply by default)
    uses_relative = ['ftp', 'http', 'gopher', 'nntp', 'imap',
                     'wais', 'file', 'https', 'shttp', 'mms',
                     'prospero', 'rtsp', 'rtspu', '', 'sftp',
                     'svn', 'svn+ssh', 'ws', 'wss']
    
    

    Note the '' in the list.

    1. First it needs to be first one for easy identification.
    2. It needs to be clarified. '' means apply by default does not help the reader.

    @orsenthil orsenthil added the 3.7 (EOL) end of life label Apr 4, 2017
    @orsenthil orsenthil self-assigned this Apr 4, 2017
    @orsenthil orsenthil added the type-bug An unexpected behavior, bug, or error label Apr 4, 2017
    @orsenthil
    Copy link
    Member Author

    #984 proposes a change. I'll need some reviews on this changed text.

    Note: I am aware that there is an issue (long pending), which suggests deal away with these schemes at the top. If we get to that immediately, I will be happy, if not, consider this PR as the improvement over the status quo.

    @orsenthil
    Copy link
    Member Author

    New changeset 906f533 by Senthil Kumaran in branch 'master':
    bpo-29976: urllib.parse clarify '' in scheme values. (GH-984)
    906f533

    @orsenthil
    Copy link
    Member Author

    New changeset a2a8226 by Senthil Kumaran in branch '3.5':
    bpo-29976: urllib.parse clarify '' in scheme values. (GH-984) (GH-1693)
    a2a8226

    @orsenthil
    Copy link
    Member Author

    New changeset b5bf7e8 by Senthil Kumaran in branch '3.6':
    bpo-29976: urllib.parse clarify '' in scheme values. (GH-984) (GH-1692)
    b5bf7e8

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant