Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing FTP support in urllib shouldn't use Debian FTP server #74350

Closed
serhiy-storchaka opened this issue Apr 26, 2017 · 3 comments
Closed

Testing FTP support in urllib shouldn't use Debian FTP server #74350

serhiy-storchaka opened this issue Apr 26, 2017 · 3 comments
Assignees
Labels
3.7 (EOL) end of life tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

BPO 30164
Nosy @orsenthil, @serhiy-storchaka, @miss-islington
PRs
  • bpo-30164 Add return statements in ftplib demo. #25968
  • [3.10] bpo-30164 Add missing return statements in ftplib documentation. (GH-25968) #25969
  • [3.9] bpo-30164 - Add missing return statements in ftplib documentation. (GH-25968) #25970
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/orsenthil'
    closed_at = <Date 2021-05-07.13:50:48.703>
    created_at = <Date 2017-04-26.04:50:03.025>
    labels = ['3.7', 'type-bug', 'tests']
    title = "Testing FTP support in urllib shouldn't use Debian FTP server"
    updated_at = <Date 2021-05-07.14:12:57.185>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2021-05-07.14:12:57.185>
    actor = 'miss-islington'
    assignee = 'orsenthil'
    closed = True
    closed_date = <Date 2021-05-07.13:50:48.703>
    closer = 'orsenthil'
    components = ['Tests']
    creation = <Date 2017-04-26.04:50:03.025>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 30164
    keywords = []
    message_count = 3.0
    messages = ['292299', '292300', '393184']
    nosy_count = 3.0
    nosy_names = ['orsenthil', 'serhiy.storchaka', 'miss-islington']
    pr_nums = ['25968', '25969', '25970']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue30164'
    versions = ['Python 2.7', 'Python 3.5', 'Python 3.6', 'Python 3.7']

    @serhiy-storchaka
    Copy link
    Member Author

    test_urllib2net.py uses ftp://ftp.debian.org/ for testing FTP support in urllib. But Debian just announced shutting down its public FTP services.

    https://lists.debian.org/debian-announce/2017/msg00001.html

    @serhiy-storchaka serhiy-storchaka added 3.7 (EOL) end of life tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Apr 26, 2017
    @orsenthil
    Copy link
    Member

    I had started taking some action on it recently: python/pythondotorg#1069

    I verified that only one test module is affected and rest of our ftp.debian.org references are examples/docstrings that will need to be updated eventually too.

    @orsenthil orsenthil self-assigned this Apr 26, 2017
    @orsenthil
    Copy link
    Member

    This has been fixed here - https://github.com/python/cpython/pull/2755/files

    Python docs demonstrate the usage of ftplib using ftp.debian.org.
    I think, it is perfectly reasonable and welcome thing to do so.

    https://docs.python.org/3/library/ftplib.html

    Closing this ticket as fixed. I will add some minor improvement to the documentation usage though.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants