Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change "-- more --" text in pager module #74629

Closed
gautamkrishnar mannequin opened this issue May 23, 2017 · 7 comments
Closed

Add ability to change "-- more --" text in pager module #74629

gautamkrishnar mannequin opened this issue May 23, 2017 · 7 comments
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@gautamkrishnar
Copy link
Mannequin

gautamkrishnar mannequin commented May 23, 2017

BPO 30444
Nosy @rhettinger, @stevendaprano, @serhiy-storchaka, @gautamkrishnar
PRs
  • bpo-30444: Added ability to set pager module's see more text #1774
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-07-08.14:35:41.694>
    created_at = <Date 2017-05-23.22:28:32.078>
    labels = ['3.7', 'type-feature', 'library']
    title = 'Add ability to change "-- more --" text in pager module'
    updated_at = <Date 2017-07-08.14:35:41.692>
    user = 'https://github.com/gautamkrishnar'

    bugs.python.org fields:

    activity = <Date 2017-07-08.14:35:41.692>
    actor = 'Gautam krishna.R'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-07-08.14:35:41.694>
    closer = 'Gautam krishna.R'
    components = ['Library (Lib)']
    creation = <Date 2017-05-23.22:28:32.078>
    creator = 'Gautam krishna.R'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 30444
    keywords = []
    message_count = 7.0
    messages = ['294290', '294294', '294327', '294580', '294599', '294601', '297956']
    nosy_count = 4.0
    nosy_names = ['rhettinger', 'steven.daprano', 'serhiy.storchaka', 'Gautam krishna.R']
    pr_nums = ['1774']
    priority = 'normal'
    resolution = None
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue30444'
    versions = ['Python 3.7']

    @gautamkrishnar
    Copy link
    Mannequin Author

    gautamkrishnar mannequin commented May 23, 2017

    Need ability to change the text

    @gautamkrishnar gautamkrishnar mannequin added the stdlib Python modules in the Lib dir label May 23, 2017
    @gautamkrishnar gautamkrishnar mannequin changed the title Add ability to change "-- more -- Add ability to change "-- more --" text in pager module May 23, 2017
    @gautamkrishnar gautamkrishnar mannequin added the type-feature A feature request or enhancement label May 23, 2017
    @stevendaprano
    Copy link
    Member

    Can you please explain why you need to change the --more-- text in the pager?

    I haven't been able to find any way to change the "--more--" prompt in the shell commands less and more, and remember that the pager will under some circumstances use one of those.

    @stevendaprano stevendaprano added the 3.7 (EOL) end of life label May 23, 2017
    @gautamkrishnar
    Copy link
    Mannequin Author

    gautamkrishnar mannequin commented May 24, 2017

    While i was working on one of my personal project i thought of using pager module for piping the output in the terminal, please see the issue:
    gautamkrishnar/socli#46

    Adding ability to modify "-- more --" (statically specified text will allow us to change its value to something like "- Press enter to see more..." or any other value...

    @serhiy-storchaka
    Copy link
    Member

    pydoc.pager() is not a public API. This is an internal function of the pydoc module. The stdlib does not have a benefit from adding this feature.

    @gautamkrishnar
    Copy link
    Mannequin Author

    gautamkrishnar mannequin commented May 27, 2017

    Yes even if it was built for PyDoc why cant we can extend its functionality to make it work with others too, Without breaking its current functionality...

    @rhettinger
    Copy link
    Contributor

    My preference is to keep pydoc focused on its primary task.

    This proposal seems like "feature creep" and the benefit is of questionable importance.

    @gautamkrishnar
    Copy link
    Mannequin Author

    gautamkrishnar mannequin commented Jul 8, 2017

    Thank you! closing this due to inncativity..

    @gautamkrishnar gautamkrishnar mannequin closed this as completed Jul 8, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants