Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate zipfile.py pypy issue #905 patch to CPython 2.7 #74652

Closed
shubharamani mannequin opened this issue May 24, 2017 · 3 comments
Closed

Propagate zipfile.py pypy issue #905 patch to CPython 2.7 #74652

shubharamani mannequin opened this issue May 24, 2017 · 3 comments
Labels
performance Performance or resource usage

Comments

@shubharamani
Copy link
Mannequin

shubharamani mannequin commented May 24, 2017

BPO 30467
Nosy @serhiy-storchaka, @shubharamani
Superseder
  • bpo-30468: Propagate zipfile.py pypy issue bpo-29887: Test normalization now fails if download fails #905 patch to CPython 3.7
  • Files
  • issue905.diff: patch which was applied to PyPy code base
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-05-25.10:48:42.908>
    created_at = <Date 2017-05-24.23:06:33.470>
    labels = ['performance']
    title = 'Propagate zipfile.py pypy issue #905 patch to CPython 2.7'
    updated_at = <Date 2017-05-25.15:21:44.401>
    user = 'https://github.com/shubharamani'

    bugs.python.org fields:

    activity = <Date 2017-05-25.15:21:44.401>
    actor = 'shubhar'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-05-25.10:48:42.908>
    closer = 'serhiy.storchaka'
    components = []
    creation = <Date 2017-05-24.23:06:33.470>
    creator = 'shubhar'
    dependencies = []
    files = ['46898']
    hgrepos = []
    issue_num = 30467
    keywords = ['patch']
    message_count = 3.0
    messages = ['294411', '294462', '294489']
    nosy_count = 2.0
    nosy_names = ['serhiy.storchaka', 'shubhar']
    pr_nums = []
    priority = 'normal'
    resolution = 'duplicate'
    stage = 'resolved'
    status = 'closed'
    superseder = '30468'
    type = 'performance'
    url = 'https://bugs.python.org/issue30467'
    versions = ['Python 2.7']

    @shubharamani
    Copy link
    Mannequin Author

    shubharamani mannequin commented May 24, 2017

    PyPy had a longstanding issue :
    ZipFile.extractall is very slow compared to CPython 2.6

    https://bitbucket.org/pypy/pypy/issues/905/zipfileextractall-is-very-slow-compared-to

    which has been fixed in the PyPy code base. The changes were entirely in zipfile.py (see the attached patch for PyPy)

    The patch fixed a significant performance bottleneck in PyPy.

    @shubharamani shubharamani mannequin added the performance Performance or resource usage label May 24, 2017
    @shubharamani shubharamani mannequin changed the title Propagate zipfile.py pypy issue #905 patch to CPython Propagate zipfile.py pypy issue #905 patch to CPython 2.7 May 24, 2017
    @serhiy-storchaka
    Copy link
    Member

    This is the same as bpo-30468. It isn't worth to open separate issues for different versions.

    @shubharamani
    Copy link
    Mannequin Author

    shubharamani mannequin commented May 25, 2017

    Please assign this bug to me.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    performance Performance or resource usage
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant