Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated note in set documentation #74684

Closed
JulienPalard opened this issue May 28, 2017 · 7 comments
Closed

Deprecated note in set documentation #74684

JulienPalard opened this issue May 28, 2017 · 7 comments
Assignees
Labels
3.7 (EOL) end of life docs Documentation in the Doc dir

Comments

@JulienPalard
Copy link
Member

BPO 30499
Nosy @rhettinger, @JulienPalard, @Mariatta
PRs
  • bpo-30499: Remove a deprecated note about sets. #1848
  • [3.6] bpo-30499: Remove a deprecated note about sets. (GH-1848) #1905
  • [3.5] bpo-30499: Remove a deprecated note about sets. (GH-1848) #1906
  • [2.7] bpo-30499: Remove a deprecated note about sets. (GH-1848) #1907
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/Mariatta'
    closed_at = <Date 2017-06-01.14:13:51.398>
    created_at = <Date 2017-05-28.21:30:17.928>
    labels = ['3.7', 'docs']
    title = 'Deprecated note in set documentation'
    updated_at = <Date 2017-06-01.14:13:51.396>
    user = 'https://github.com/JulienPalard'

    bugs.python.org fields:

    activity = <Date 2017-06-01.14:13:51.396>
    actor = 'Mariatta'
    assignee = 'Mariatta'
    closed = True
    closed_date = <Date 2017-06-01.14:13:51.398>
    closer = 'Mariatta'
    components = ['Documentation']
    creation = <Date 2017-05-28.21:30:17.928>
    creator = 'mdk'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 30499
    keywords = []
    message_count = 7.0
    messages = ['294662', '294904', '294940', '294941', '294942', '294943', '294944']
    nosy_count = 4.0
    nosy_names = ['rhettinger', 'docs@python', 'mdk', 'Mariatta']
    pr_nums = ['1848', '1905', '1906', '1907']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue30499'
    versions = ['Python 2.7', 'Python 3.5', 'Python 3.6', 'Python 3.7']

    @JulienPalard
    Copy link
    Member Author

    While translating doc to french, I found a surprising comment in stdtypes.html about sets, stating:

    To support searching for an equivalent frozenset, the elem set is temporarily mutated during the search and then restored. During the search, the elem set should not be read or mutated since it does not have a meaningful value.

    So I searched the equivalent in the code, at least to help me understand it to translate it in a proper way, but found it has been deleted in 51ced7a.

    This commit is in branches 2.7 and 3.1 to 3.6 (and master).

    @JulienPalard JulienPalard added the docs Documentation in the Doc dir label May 28, 2017
    @rhettinger rhettinger assigned rhettinger and unassigned docspython May 29, 2017
    @Mariatta Mariatta added the 3.7 (EOL) end of life label Jun 1, 2017
    @rhettinger
    Copy link
    Contributor

    This is good to go.

    @rhettinger rhettinger assigned Mariatta and unassigned rhettinger Jun 1, 2017
    @Mariatta
    Copy link
    Member

    Mariatta commented Jun 1, 2017

    New changeset 0737ee2 by Mariatta (Julien) in branch 'master':
    bpo-30499: Remove a deprecated note about sets. (GH-1848)
    0737ee2

    @Mariatta
    Copy link
    Member

    Mariatta commented Jun 1, 2017

    New changeset 9d752aa by Mariatta in branch '3.6':
    bpo-30499: Remove a deprecated note about sets. (GH-1848) (GH-1905)
    9d752aa

    @Mariatta
    Copy link
    Member

    Mariatta commented Jun 1, 2017

    New changeset 3419fc2 by Mariatta in branch '3.5':
    bpo-30499: Remove a deprecated note about sets. (GH-1848) (GH-1906)
    3419fc2

    @Mariatta
    Copy link
    Member

    Mariatta commented Jun 1, 2017

    New changeset 662d856 by Mariatta in branch '2.7':
    bpo-30499: Remove a deprecated note about sets. (GH-1848) (GH-1907)
    662d856

    @Mariatta
    Copy link
    Member

    Mariatta commented Jun 1, 2017

    Thanks Julien and Raymond.
    PR has been merged and backported to 2.7, 3.5 and 3.6.

    @Mariatta Mariatta closed this as completed Jun 1, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life docs Documentation in the Doc dir
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants