Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textwrap: placeholder backtracking special case lacks test coverage #74776

Closed
jonathaneunice mannequin opened this issue Jun 7, 2017 · 2 comments
Closed

textwrap: placeholder backtracking special case lacks test coverage #74776

jonathaneunice mannequin opened this issue Jun 7, 2017 · 2 comments
Labels
3.7 (EOL) end of life tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@jonathaneunice
Copy link
Mannequin

jonathaneunice mannequin commented Jun 7, 2017

BPO 30591
Nosy @serhiy-storchaka, @jonathaneunice
PRs
  • bpo-30591: added test for textwrap backtracking #1988
  • bpo-30620: remove bogus/dead lines from dedent #2064
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-06-07.20:51:14.622>
    created_at = <Date 2017-06-07.16:40:44.785>
    labels = ['3.7', 'type-feature', 'tests']
    title = 'textwrap: placeholder backtracking special case lacks test coverage'
    updated_at = <Date 2017-06-10.04:17:35.490>
    user = 'https://github.com/jonathaneunice'

    bugs.python.org fields:

    activity = <Date 2017-06-10.04:17:35.490>
    actor = 'jonathaneunice'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-06-07.20:51:14.622>
    closer = 'serhiy.storchaka'
    components = ['Tests']
    creation = <Date 2017-06-07.16:40:44.785>
    creator = 'jonathaneunice'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 30591
    keywords = []
    message_count = 2.0
    messages = ['295354', '295368']
    nosy_count = 2.0
    nosy_names = ['serhiy.storchaka', 'jonathaneunice']
    pr_nums = ['1988', '2064']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue30591'
    versions = ['Python 3.7']

    @jonathaneunice
    Copy link
    Mannequin Author

    jonathaneunice mannequin commented Jun 7, 2017

    A rare case in textwrap when max_lines insufficient and textwrap needs to backtrack to a previous line to add the placeholder seems to lack test coverage.

    This issue added as prereq for suggesting an additional test. PR imminent.

    Code: Lib/textwrap.py (as is)
    Test: Lib/test/test_textwrap.py (extended)

    @jonathaneunice jonathaneunice mannequin added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Jun 7, 2017
    @serhiy-storchaka
    Copy link
    Member

    New changeset 5edf827 by Serhiy Storchaka (Jonathan Eunice) in branch 'master':
    bpo-30591: Added test for textwrap backtracking. (bpo-1988)
    5edf827

    @serhiy-storchaka serhiy-storchaka added the 3.7 (EOL) end of life label Jun 7, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant