Compile failure for linux socket CAN support

[xrmx]

BPO	30864
Nosy	@xrmx, @ZackerySpytz

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2017-07-06.08:36:05.380>
labels = ['expert-IO']
title = 'Compile failure for linux socket CAN support'
updated_at = <Date 2019-07-22.23:40:05.966>
user = 'https://github.com/xrmx'

bugs.python.org fields:

activity = <Date 2019-07-22.23:40:05.966>
actor = 'ZackerySpytz'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['IO']
creation = <Date 2017-07-06.08:36:05.380>
creator = 'Riccardo Magliocchetti'
dependencies = []
files = []
hgrepos = []
issue_num = 30864
keywords = []
message_count = 2.0
messages = ['297816', '348311']
nosy_count = 2.0
nosy_names = ['Riccardo Magliocchetti', 'ZackerySpytz']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue30864'
versions = ['Python 3.6']

[xrmx]

I have an issue related to this while trying to compile statically Python 3.6.1 (but latest master looks the same) against a static musl.

The problem is that i have AF_CAN defined because it's defined in linux/socket.h but by not having HAVE_LINUX_CAN_H defined in pyconfig.h the header which contains the definition of struct sockaddr_can is not included. I think (at least for linux) using AF_CAN for the conditionals is wrong and the HAVE_LINUX_CAN_H should be used instead.

I think the same applies for CAN_RAW and CAN_BCM because they are defined in the generic linux/can.h and not in a feature specific header.

Reference:
http://bugs.python.org/issue10141

[ZackerySpytz]

It seems that the AF_CAN issue was fixed in bpo-31927 / d318715.