FAIL: test_last_modified (test.test_httpservers.SimpleHTTPServerTestCase), on AMD64 Windows8.1 Non-Debug 3.x

[vstinner]

BPO	31066
Nosy	@vstinner
PRs	bpo-31066: Fix test_httpservers.test_last_modified() #2933

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2017-07-28.16:19:12.753>
created_at = <Date 2017-07-28.13:14:47.381>
labels = ['3.7', 'tests']
title = 'FAIL: test_last_modified (test.test_httpservers.SimpleHTTPServerTestCase), on AMD64 Windows8.1 Non-Debug 3.x'
updated_at = <Date 2017-07-28.16:19:12.752>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2017-07-28.16:19:12.752>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2017-07-28.16:19:12.753>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2017-07-28.13:14:47.381>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 31066
keywords = []
message_count = 3.0
messages = ['299385', '299400', '299404']
nosy_count = 1.0
nosy_names = ['vstinner']
pr_nums = ['2933']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue31066'
versions = ['Python 3.7']

[vstinner]

http://buildbot.python.org/all/builders/AMD64%20Windows8.1%20Non-Debug%203.x/builds/985/steps/test/logs/stdio

======================================================================
FAIL: test_last_modified (test.test_httpservers.SimpleHTTPServerTestCase)
Checks that the datetime returned in Last-Modified response header
----------------------------------------------------------------------

Traceback (most recent call last):
  File "D:\buildarea\3.x.ware-win81-release\build\lib\test\test_httpservers.py", line 512, in test_last_modified
    self.assertEqual(last_modif_header, self.last_modif_header)
AssertionError: 'Fri, 28 Jul 2017 01:20:09 GMT' != 'Fri, 28 Jul 2017 01:20:06 GMT'
- Fri, 28 Jul 2017 01:20:09 GMT
?                         ^
+ Fri, 28 Jul 2017 01:20:06 GMT
?                         ^

[vstinner]

I can reproduce the failure if I insert time.sleep(1) after os.fstat().

Attached PR should fix the race condition.

[vstinner]

New changeset 28ce07a by Victor Stinner in branch 'master':
bpo-31066: Fix test_httpservers.test_last_modified() (bpo-2933)
28ce07a