Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 warning F401: ... imported but unused #76337

Closed
vstinner opened this issue Nov 28, 2017 · 4 comments
Closed

Fix flake8 warning F401: ... imported but unused #76337

vstinner opened this issue Nov 28, 2017 · 4 comments
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir

Comments

@vstinner
Copy link
Member

BPO 32156
Nosy @terryjreedy, @vstinner, @serhiy-storchaka
PRs
  • bpo-32156: Remove unused imports #4614
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-05-29.21:52:08.484>
    created_at = <Date 2017-11-28.15:07:16.018>
    labels = ['3.7', 'library']
    title = 'Fix flake8 warning F401: ... imported but unused'
    updated_at = <Date 2018-05-29.21:52:08.483>
    user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2018-05-29.21:52:08.483>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-05-29.21:52:08.484>
    closer = 'vstinner'
    components = ['Library (Lib)']
    creation = <Date 2017-11-28.15:07:16.018>
    creator = 'vstinner'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 32156
    keywords = ['patch']
    message_count = 4.0
    messages = ['307126', '307141', '307205', '318106']
    nosy_count = 3.0
    nosy_names = ['terry.reedy', 'vstinner', 'serhiy.storchaka']
    pr_nums = ['4614']
    priority = 'normal'
    resolution = 'out of date'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue32156'
    versions = ['Python 3.7']

    @vstinner
    Copy link
    Member Author

    Attached PR removes unused imports.

    @vstinner vstinner added 3.7 (EOL) end of life stdlib Python modules in the Lib dir labels Nov 28, 2017
    @serhiy-storchaka
    Copy link
    Member

    I suggest to split your patch on several PR for different domains, and let the domain experts review changes separately. IDLE changes look mostly harmless to me. But changes in distutils should be made with a large care.

    @terryjreedy
    Copy link
    Member

    Idlelib deletions done.
    pathbrowser, bpo-32100, PR-4626
    configdialog, bpo-30781, PR-4627

    @vstinner
    Copy link
    Member Author

    I suggest to split your patch on several PR for different domains, and let the domain experts review changes separately.

    Right. I should recreate multiple PRs with fewer changes per PR.

    I close this issue.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants