Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make patchcheck.py work for out-of-tree builds #76437

Closed
izbyshev mannequin opened this issue Dec 9, 2017 · 7 comments
Closed

Make patchcheck.py work for out-of-tree builds #76437

izbyshev mannequin opened this issue Dec 9, 2017 · 7 comments
Labels
3.7 (EOL) end of life type-feature A feature request or enhancement

Comments

@izbyshev
Copy link
Mannequin

izbyshev mannequin commented Dec 9, 2017

BPO 32256
Nosy @abalkin, @vstinner, @merwok, @izbyshev, @miss-islington
PRs
  • bpo-32256: Make patchcheck.py work for out-of-tree builds #4760
  • [3.7] bpo-32256: Make patchcheck.py work for out-of-tree builds (GH-4760) #9992
  • [3.6] bpo-32256: Make patchcheck.py work for out-of-tree builds (GH-4760) #9993
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-10-20.20:42:50.892>
    created_at = <Date 2017-12-09.01:35:58.554>
    labels = ['type-feature', '3.7']
    title = 'Make patchcheck.py work for out-of-tree builds'
    updated_at = <Date 2018-10-20.20:42:50.890>
    user = 'https://github.com/izbyshev'

    bugs.python.org fields:

    activity = <Date 2018-10-20.20:42:50.890>
    actor = 'izbyshev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-10-20.20:42:50.892>
    closer = 'izbyshev'
    components = []
    creation = <Date 2017-12-09.01:35:58.554>
    creator = 'izbyshev'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 32256
    keywords = ['patch']
    message_count = 7.0
    messages = ['307875', '310675', '328115', '328119', '328120', '328121', '328178']
    nosy_count = 5.0
    nosy_names = ['belopolsky', 'vstinner', 'eric.araujo', 'izbyshev', 'miss-islington']
    pr_nums = ['4760', '9992', '9993']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue32256'
    versions = ['Python 3.7']

    @izbyshev
    Copy link
    Mannequin Author

    izbyshev mannequin commented Dec 9, 2017

    Despite some steps made in bpo-9860 make patchcheck still doesn't work for out-of-tree builds because it runs git and hg in the current directory instead of the source directory (msg169465).

    @izbyshev izbyshev mannequin added 3.7 (EOL) end of life type-feature A feature request or enhancement labels Dec 9, 2017
    @izbyshev
    Copy link
    Mannequin Author

    izbyshev mannequin commented Jan 25, 2018

    Any objections to the PR?

    @vstinner
    Copy link
    Member

    New changeset aa95bfb by Victor Stinner (Alexey Izbyshev) in branch 'master':
    bpo-32256: Make patchcheck.py work for out-of-tree builds (GH-4760)
    aa95bfb

    @miss-islington
    Copy link
    Contributor

    New changeset 1662bbf by Miss Islington (bot) in branch '3.7':
    bpo-32256: Make patchcheck.py work for out-of-tree builds (GH-4760)
    1662bbf

    @miss-islington
    Copy link
    Contributor

    New changeset 42c52a9 by Miss Islington (bot) in branch '3.6':
    bpo-32256: Make patchcheck.py work for out-of-tree builds (GH-4760)
    42c52a9

    @vstinner
    Copy link
    Member

    Thanks Alexey Izbyshev!

    @izbyshev
    Copy link
    Mannequin Author

    izbyshev mannequin commented Oct 20, 2018

    Thank you for testing and merging, Victor!

    @izbyshev izbyshev mannequin closed this as completed Oct 20, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants