Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for 'break' and 'return' inside 'finally' clause #76659

Closed
serhiy-storchaka opened this issue Jan 1, 2018 · 4 comments
Closed

Add tests for 'break' and 'return' inside 'finally' clause #76659

serhiy-storchaka opened this issue Jan 1, 2018 · 4 comments
Labels
3.7 (EOL) end of life tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 32478
Nosy @serhiy-storchaka
PRs
  • bpo-32478: Add tests for 'break' and 'return' inside 'finally' clause. #5078
  • [3.6] bpo-32478: Add tests for 'break' and 'return' inside 'finally' clause. (GH-5078) #5080
  • [3.6] bpo-32478: Add tests for 'break' and 'return' inside 'finally' clause. (GH-5078) #5083
  • [2.7] bpo-32478: Add tests for 'break' and 'return' inside 'finally' clause. (GH-5078). #5084
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-01-02.08:59:00.673>
    created_at = <Date 2018-01-01.22:52:03.371>
    labels = ['3.7', 'type-feature', 'tests']
    title = "Add tests for 'break' and 'return' inside 'finally' clause"
    updated_at = <Date 2018-01-02.08:59:00.672>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2018-01-02.08:59:00.672>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-01-02.08:59:00.673>
    closer = 'serhiy.storchaka'
    components = ['Tests']
    creation = <Date 2018-01-01.22:52:03.371>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 32478
    keywords = ['patch']
    message_count = 4.0
    messages = ['309352', '309354', '309358', '309361']
    nosy_count = 1.0
    nosy_names = ['serhiy.storchaka']
    pr_nums = ['5078', '5080', '5083', '5084']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue32478'
    versions = ['Python 3.7']

    @serhiy-storchaka
    Copy link
    Member Author

    'break' and 'return' are never used inside 'finally' clause in the stdlib. Therefore these cases are not covered by tests even implicitly. The proposed patch adds explicit tests for them.

    'continue' inside 'finally' clause currently is prohibited (see bpo-1542451) and there are tests for this.

    @serhiy-storchaka serhiy-storchaka added 3.7 (EOL) end of life tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Jan 1, 2018
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 7cc42c3 by Serhiy Storchaka in branch 'master':
    bpo-32478: Add tests for 'break' and 'return' inside 'finally' clause. (bpo-5078)
    7cc42c3

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset aea95c2 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6':
    bpo-32478: Add tests for 'break' and 'return' inside 'finally' clause. (GH-5078) (bpo-5083)
    aea95c2

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset b495377 by Serhiy Storchaka in branch '2.7':
    [2.7] bpo-32478: Add tests for 'break' and 'return' inside 'finally' clause. (GH-5078). (bpo-5084)
    b495377

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant