Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse a testing implementation of the path protocol in tests #77145

Closed
serhiy-storchaka opened this issue Feb 27, 2018 · 5 comments
Closed

Reuse a testing implementation of the path protocol in tests #77145

serhiy-storchaka opened this issue Feb 27, 2018 · 5 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 32964
Nosy @brettcannon, @ezio-melotti, @serhiy-storchaka, @miss-islington
PRs
  • bpo-32964: Reuse a testing implementation of the path protocol in tests. #5930
  • [3.7] bpo-32964: Reuse a testing implementation of the path protocol in tests. (GH-5930) #5957
  • [3.6] bpo-32964: Reuse a testing implementation of the path protocol in tests. (GH-5930). #5958
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-03-03.12:19:54.341>
    created_at = <Date 2018-02-27.19:40:07.400>
    labels = ['3.7', '3.8', 'type-feature', 'tests']
    title = 'Reuse a testing implementation of the path protocol in tests'
    updated_at = <Date 2018-03-03.12:19:54.340>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2018-03-03.12:19:54.340>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-03-03.12:19:54.341>
    closer = 'serhiy.storchaka'
    components = ['Tests']
    creation = <Date 2018-02-27.19:40:07.400>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 32964
    keywords = ['patch']
    message_count = 5.0
    messages = ['313018', '313067', '313128', '313129', '313186']
    nosy_count = 4.0
    nosy_names = ['brett.cannon', 'ezio.melotti', 'serhiy.storchaka', 'miss-islington']
    pr_nums = ['5930', '5957', '5958']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue32964'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

    @serhiy-storchaka
    Copy link
    Member Author

    In a number of tests there are simple implementations of the path protocol. Unlike to pathlib.Path they implement only necessary minimum of methods. The proposed PR moves this implementation into test.support. It also fixes some misuses of it.

    I have named it SimplePath. Are there better ideas? PathLike was rejected due to possible confusion with os.PathLike.

    @serhiy-storchaka serhiy-storchaka added 3.7 (EOL) end of life 3.8 only security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Feb 27, 2018
    @brettcannon
    Copy link
    Member

    FakePath? Otherwise SimplePath seems as good a name as any other one.

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset b21d155 by Serhiy Storchaka in branch 'master':
    bpo-32964: Reuse a testing implementation of the path protocol in tests. (bpo-5930)
    b21d155

    @miss-islington
    Copy link
    Contributor

    New changeset a13b654 by Miss Islington (bot) in branch '3.7':
    bpo-32964: Reuse a testing implementation of the path protocol in tests. (GH-5930)
    a13b654

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset fbdd075 by Serhiy Storchaka in branch '3.6':
    [3.6] bpo-32964: Reuse a testing implementation of the path protocol in tests. (GH-5930). (GH-5958)
    fbdd075

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants