Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contextvars documentation incorrectly refers to "non-local state". #77547

Closed
tomchristie mannequin opened this issue Apr 26, 2018 · 4 comments
Closed

contextvars documentation incorrectly refers to "non-local state". #77547

tomchristie mannequin opened this issue Apr 26, 2018 · 4 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes docs Documentation in the Doc dir topic-asyncio type-feature A feature request or enhancement

Comments

@tomchristie
Copy link
Mannequin

tomchristie mannequin commented Apr 26, 2018

BPO 33366
Nosy @asvetlov, @tomchristie, @1st1
PRs
  • bpo-33366: Change wording from "non-local state" to "context-local state". #6617
  • [3.7] bpo-33366: Change "non-local state" to "content-local state". (GH-6617) #6621
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-04-27.22:35:45.046>
    created_at = <Date 2018-04-26.12:47:52.352>
    labels = ['3.8', 'type-feature', '3.7', 'docs', 'expert-asyncio']
    title = '`contextvars` documentation incorrectly refers to "non-local state".'
    updated_at = <Date 2018-04-27.22:36:35.971>
    user = 'https://github.com/tomchristie'

    bugs.python.org fields:

    activity = <Date 2018-04-27.22:36:35.971>
    actor = 'miss-islington'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2018-04-27.22:35:45.046>
    closer = 'yselivanov'
    components = ['Documentation', 'asyncio']
    creation = <Date 2018-04-26.12:47:52.352>
    creator = 'tomchristie'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 33366
    keywords = ['patch']
    message_count = 4.0
    messages = ['315792', '315803', '315831', '315861']
    nosy_count = 4.0
    nosy_names = ['asvetlov', 'tomchristie', 'docs@python', 'yselivanov']
    pr_nums = ['6617', '6621']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue33366'
    versions = ['Python 3.7', 'Python 3.8']

    @tomchristie
    Copy link
    Mannequin Author

    tomchristie mannequin commented Apr 26, 2018

    The contextvars documentation, at https://docs.python.org/3.7/library/contextvars.html starts with the following:

    "This module provides APIs to manage, store, and access non-local state."

    I assume that must be a documentation bug, right. The module isn't for managing non-local state, it's for managing state that *is* local.

    I'd assume it ought to read...

    "This module provides APIs to manage, store, and access context-local state."

    (ie. for managing state that is transparently either thread-local or task-local depending on the current execution context.)

    @tomchristie tomchristie mannequin added 3.7 (EOL) end of life 3.8 only security fixes labels Apr 26, 2018
    @tomchristie tomchristie mannequin assigned docspython Apr 26, 2018
    @tomchristie tomchristie mannequin added docs Documentation in the Doc dir topic-asyncio type-feature A feature request or enhancement labels Apr 26, 2018
    @1st1
    Copy link
    Member

    1st1 commented Apr 26, 2018

    I like what you propose. Can you submit a PR? :)

    @tomchristie
    Copy link
    Mannequin Author

    tomchristie mannequin commented Apr 27, 2018

    Refs: #6617

    @1st1
    Copy link
    Member

    1st1 commented Apr 27, 2018

    Thank you, Tom!

    @1st1 1st1 closed this as completed Apr 27, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes docs Documentation in the Doc dir topic-asyncio type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant