We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
assignee = None
closed_at = <Date 2019-05-22.17:30:28.300>
created_at = <Date 2018-05-13.14:33:47.481>
labels = ['3.7', '3.8']
title = 'codecs.StreamRecoder.writelines is broken'
updated_at = <Date 2019-05-22.17:30:28.300>
user = 'https://github.com/JelleZijlstra'
activity = <Date 2019-05-22.17:30:28.300>
actor = 'gvanrossum'
assignee = 'none'
closed = True
closed_date = <Date 2019-05-22.17:30:28.300>
closer = 'gvanrossum'
components = 
creation = <Date 2018-05-13.14:33:47.481>
creator = 'JelleZijlstra'
dependencies = 
files = 
hgrepos = 
issue_num = 33482
keywords = ['patch']
message_count = 4.0
messages = ['316465', '319343', '343200', '343216']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'JelleZijlstra', 'miss-islington']
pr_nums = ['6779', '13501', '13502']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue33482'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
The text was updated successfully, but these errors were encountered:
codecs.StreamRecoder.writelines is implemented as:
def writelines(self, list):
data = ''.join(list)
data, bytesdecoded = self.decode(data, self.errors)
It can't take a list of bytes because then the ''.join throws an error, and it can't take a list of str because self.decode takes bytes.
It looks like bytes are intended (self.write takes bytes), so I'll submit a simple PR to fix this.
Sorry, something went wrong.
LGTM. Though sad there's no test that caught this. Could you add one.
New changeset b3be407 by Miss Islington (bot) (Jelle Zijlstra) in branch 'master':
bpo-33482: fix codecs.StreamRecoder.writelines (GH-6779)
New changeset 81c5ec9 by Miss Islington (bot) (Jelle Zijlstra) in branch '3.7':
[3.7] bpo-33482: fix codecs.StreamRecoder.writelines (GH-6779) (GH-13502)
No branches or pull requests