Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc Be explicit about mock_open created mocks not supporting __iter__ #78258

Closed
andresdelfino opened this issue Jul 9, 2018 · 3 comments
Closed
Labels
3.7 (EOL) end of life 3.8 only security fixes docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@andresdelfino
Copy link
Contributor

BPO 34077
Nosy @berkerpeksag, @andresdelfino
PRs
  • bpo-34077: Mention that mock_open mocks don't support __iter__ #8203
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-07-09.16:18:04.709>
    created_at = <Date 2018-07-09.15:57:57.490>
    labels = ['3.8', 'type-feature', '3.7', 'docs']
    title = 'doc Be explicit about mock_open created mocks not supporting __iter__'
    updated_at = <Date 2018-07-09.16:33:31.003>
    user = 'https://github.com/andresdelfino'

    bugs.python.org fields:

    activity = <Date 2018-07-09.16:33:31.003>
    actor = 'berker.peksag'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2018-07-09.16:18:04.709>
    closer = 'berker.peksag'
    components = ['Documentation']
    creation = <Date 2018-07-09.15:57:57.490>
    creator = 'adelfino'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 34077
    keywords = ['patch']
    message_count = 3.0
    messages = ['321327', '321333', '321335']
    nosy_count = 3.0
    nosy_names = ['docs@python', 'berker.peksag', 'adelfino']
    pr_nums = ['8203']
    priority = 'normal'
    resolution = 'rejected'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue34077'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

    @andresdelfino
    Copy link
    Contributor Author

    I've been bitten by this one, and while the docs are clear in what the created mock objects support, I think something explicit about __iter__ will help.

    @andresdelfino andresdelfino added 3.7 (EOL) end of life 3.8 only security fixes labels Jul 9, 2018
    @andresdelfino andresdelfino added docs Documentation in the Doc dir type-feature A feature request or enhancement labels Jul 9, 2018
    @berkerpeksag
    Copy link
    Member

    -1. We can't document every non-existent feature in the stdlib documentation.

    There is an already open issue for adding __iter__ support to mock_open(): bpo-21258

    @berkerpeksag
    Copy link
    Member

    There is also bpo-32933.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes docs Documentation in the Doc dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants