Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make csv.Dialect attributes skipinitialspace, doublequote and strict booleans #78378

Closed
serhiy-storchaka opened this issue Jul 23, 2018 · 4 comments
Assignees
Labels
3.8 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 34197
Nosy @serhiy-storchaka, @tirkarthi
PRs
  • bpo-34197: Make _csv.Dialect attributes booleans. #8440
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2018-07-26.11:35:42.846>
    created_at = <Date 2018-07-23.11:06:28.352>
    labels = ['3.8', 'type-feature', 'library']
    title = 'Make csv.Dialect attributes skipinitialspace, doublequote and strict booleans'
    updated_at = <Date 2018-07-26.11:35:42.845>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2018-07-26.11:35:42.845>
    actor = 'serhiy.storchaka'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2018-07-26.11:35:42.846>
    closer = 'serhiy.storchaka'
    components = ['Library (Lib)']
    creation = <Date 2018-07-23.11:06:28.352>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 34197
    keywords = ['patch']
    message_count = 4.0
    messages = ['322193', '322309', '322312', '322410']
    nosy_count = 2.0
    nosy_names = ['serhiy.storchaka', 'xtreak']
    pr_nums = ['8440']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue34197'
    versions = ['Python 3.8']

    @serhiy-storchaka
    Copy link
    Member Author

    Currently attributes skipinitialspace, doublequote and strict of the csv.Dialect class are integers 0 or 1.

    >>> import csv
    >>> d = csv.reader([]).dialect
    >>> d.skipinitialspace
    0
    >>> d.doublequote
    1
    >>> d.strict
    0

    The proposed PR makes them False or True.

    @serhiy-storchaka serhiy-storchaka added the 3.8 (EOL) end of life label Jul 23, 2018
    @serhiy-storchaka serhiy-storchaka self-assigned this Jul 23, 2018
    @serhiy-storchaka serhiy-storchaka added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Jul 23, 2018
    @tirkarthi
    Copy link
    Member

    The proposed PR makes them False or True.

    Sorry, is there a PR missing here? I hope you are referring to serhiy-storchaka@f96e696

    Thanks

    @serhiy-storchaka
    Copy link
    Member Author

    Hmm, indeed, I forgot to create a PR. Thank you for catching this Karthikeyan!

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 323748a by Serhiy Storchaka in branch 'master':
    bpo-34197: Make _csv.Dialect attributes booleans. (GH-8440)
    323748a

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants