Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs of sys.exit() mention utf8_mode for an unclear reason #78683

Closed
izbyshev mannequin opened this issue Aug 25, 2018 · 6 comments
Closed

Docs of sys.exit() mention utf8_mode for an unclear reason #78683

izbyshev mannequin opened this issue Aug 25, 2018 · 6 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes docs Documentation in the Doc dir

Comments

@izbyshev
Copy link
Mannequin

izbyshev mannequin commented Aug 25, 2018

BPO 34502
Nosy @vstinner, @benjaminp, @izbyshev, @miss-islington
PRs
  • bpo-34502: Remove a note about utf8_mode from sys.exit() docs #8928
  • [3.7] closes bpo-34502: Remove a note about utf8_mode from sys.exit() docs. (GH-8928) #8929
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-08-27.14:55:36.362>
    created_at = <Date 2018-08-25.17:54:28.106>
    labels = ['3.7', '3.8', 'docs']
    title = 'Docs of sys.exit() mention utf8_mode for an unclear reason'
    updated_at = <Date 2018-08-27.14:55:36.361>
    user = 'https://github.com/izbyshev'

    bugs.python.org fields:

    activity = <Date 2018-08-27.14:55:36.361>
    actor = 'vstinner'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2018-08-27.14:55:36.362>
    closer = 'vstinner'
    components = ['Documentation']
    creation = <Date 2018-08-25.17:54:28.106>
    creator = 'izbyshev'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 34502
    keywords = ['patch']
    message_count = 6.0
    messages = ['324086', '324087', '324089', '324174', '324182', '324183']
    nosy_count = 5.0
    nosy_names = ['vstinner', 'benjamin.peterson', 'docs@python', 'izbyshev', 'miss-islington']
    pr_nums = ['8928', '8929']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue34502'
    versions = ['Python 3.7', 'Python 3.8']

    @izbyshev
    Copy link
    Mannequin Author

    izbyshev mannequin commented Aug 25, 2018

    Docs for sys.exit() contain the following note added in https://github.com/python/cpython/blame/1871a4a35123b278443b960255cb14314ce196f6/Doc/library/sys.rst#L336

    Changed in version 3.7: Added utf8_mode attribute for the new -X utf8 flag.

    Does it belong to the adjacent docs for sys.flags (though they mention utf8_mode too)?

    @izbyshev izbyshev mannequin added 3.7 (EOL) end of life 3.8 only security fixes labels Aug 25, 2018
    @izbyshev izbyshev mannequin assigned docspython Aug 25, 2018
    @izbyshev izbyshev mannequin added the docs Documentation in the Doc dir label Aug 25, 2018
    @benjaminp
    Copy link
    Contributor

    New changeset 44838be by Benjamin Peterson (Alexey Izbyshev) in branch 'master':
    closes bpo-34502: Remove a note about utf8_mode from sys.exit() docs. (GH-8928)
    44838be

    @miss-islington
    Copy link
    Contributor

    New changeset 42a1ca6 by Miss Islington (bot) in branch '3.7':
    closes bpo-34502: Remove a note about utf8_mode from sys.exit() docs. (GH-8928)
    42a1ca6

    @vstinner
    Copy link
    Member

    Yes, it's a note for sys.flags. Can you please add it back to sys.flags?

    Sorry, I added the note at the wrong place.

    @vstinner vstinner reopened this Aug 27, 2018
    @izbyshev
    Copy link
    Mannequin Author

    izbyshev mannequin commented Aug 27, 2018

    Victor, but sys.flags docs *do* contain the note[1]:

    Changed in version 3.7: Added dev_mode attribute for the new -X dev flag and utf8_mode attribute for the new -X utf8 flag.

    I've tried to express that in msg324086, but obviously failed.

    [1] https://docs.python.org/3/library/sys.html#sys.flags

    @vstinner
    Copy link
    Member

    Ah ok, in this case, everything is fine :-)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes docs Documentation in the Doc dir
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants