Launcher does not validate major versions

[bgerrity]

BPO	34565
Nosy	@pfmoore, @tjguk, @ned-deily, @zware, @serhiy-storchaka, @zooba, @bgerrity
PRs	bpo-34565: Validate major version in launcher #9037 [3.7] bpo-34565: Change a PC/launcher.c comment to accurately describe valid major versions. (GH-9037) #9065

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-10-15.23:18:30.595>
created_at = <Date 2018-09-02.20:03:40.425>
labels = ['3.8', 'type-bug', '3.7', 'OS-windows']
title = 'Launcher does not validate major versions'
updated_at = <Date 2018-10-15.23:18:30.593>
user = 'https://github.com/bgerrity'

bugs.python.org fields:

activity = <Date 2018-10-15.23:18:30.593>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2018-10-15.23:18:30.595>
closer = 'ned.deily'
components = ['Windows']
creation = <Date 2018-09-02.20:03:40.425>
creator = 'bgerrity'
dependencies = []
files = []
hgrepos = []
issue_num = 34565
keywords = ['patch']
message_count = 8.0
messages = ['324483', '324494', '324495', '324496', '324500', '324595', '327208', '327804']
nosy_count = 7.0
nosy_names = ['paul.moore', 'tim.golden', 'ned.deily', 'zach.ware', 'serhiy.storchaka', 'steve.dower', 'bgerrity']
pr_nums = ['9037', '9065']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34565'
versions = ['Python 3.7', 'Python 3.8']

[bgerrity]

When a version argument is passed to the launcher (e.g. py -3.4 or py -7.0), contrary to the launcher help text, the major version isn't validated as 2 or 3.

[serhiy-storchaka]

What is wrong with supporting version 7.0?

[bgerrity]

The function's comment says otherwise; I just noticed when I was messing with 34565. Supporting arbitrary major versions makes the -0 arg ambiguous so alternatively that could be the special case?

[serhiy-storchaka]

Wouldn't be better to fix a comment?

[bgerrity]

Added a commit that just changes the comment.

[zooba]

New changeset 3876af4 by Steve Dower (Brendan Gerrity) in branch 'master':
bpo-34565: Change a PC/launcher.c comment to accurately describe valid major versions. (GH-9037)
3876af4

[ned-deily]

New changeset 28dd737 by Ned Deily (Miss Islington (bot)) in branch '3.7':
bpo-34565: Change a PC/launcher.c comment to accurately describe valid major versions. (GH-9037) (GH-9065)
28dd737

[ned-deily]

I assume we can close this now. Thanks, all!