Get rid of tp_getattro and tp_setattro in pyexpat.xmlparser

[serhiy-storchaka]

BPO	34741
Nosy	@scoder, @serhiy-storchaka
PRs	bpo-34741: Get rid of tp_getattro and tp_setattro in pyexpat.xmlparser. #9422

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-10-19.15:01:12.350>
created_at = <Date 2018-09-19.14:38:57.704>
labels = ['extension-modules', 'type-feature', '3.8']
title = 'Get rid of tp_getattro and tp_setattro in pyexpat.xmlparser'
updated_at = <Date 2018-10-19.15:01:12.349>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2018-10-19.15:01:12.349>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2018-10-19.15:01:12.350>
closer = 'serhiy.storchaka'
components = ['Extension Modules']
creation = <Date 2018-09-19.14:38:57.704>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 34741
keywords = ['patch']
message_count = 2.0
messages = ['325769', '328045']
nosy_count = 3.0
nosy_names = ['scoder', 'eli.bendersky', 'serhiy.storchaka']
pr_nums = ['9422']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue34741'
versions = ['Python 3.8']

[serhiy-storchaka]

Currently pyexpat.xmlparser has the tp_getattro and tp_setattro slot for handling some attributes. The proposed PR replaces it with tp_members and tp_getset.

Benefits: constant time access, names of these attributes are added to the result of help(), no need of the __dir__() method, better structured code.

[serhiy-storchaka]

New changeset 55f8249 by Serhiy Storchaka in branch 'master':
bpo-34741: Get rid of tp_getattro and tp_setattro in pyexpat.xmlparser. (GH-9422)
55f8249