Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpooledTemporaryFile and seekable() method #79293

Closed
nubirstein mannequin opened this issue Oct 30, 2018 · 6 comments
Closed

SpooledTemporaryFile and seekable() method #79293

nubirstein mannequin opened this issue Oct 30, 2018 · 6 comments
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@nubirstein
Copy link
Mannequin

nubirstein mannequin commented Oct 30, 2018

BPO 35112
Nosy @tirkarthi
Superseder
  • bpo-26175: Fully implement IOBase abstract on SpooledTemporaryFile
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-10-30.12:49:48.855>
    created_at = <Date 2018-10-30.12:02:15.966>
    labels = ['3.7', 'type-bug', 'library']
    title = 'SpooledTemporaryFile and seekable() method'
    updated_at = <Date 2018-10-30.12:54:02.153>
    user = 'https://bugs.python.org/nubirstein'

    bugs.python.org fields:

    activity = <Date 2018-10-30.12:54:02.153>
    actor = 'xtreak'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-10-30.12:49:48.855>
    closer = 'nubirstein'
    components = ['Library (Lib)']
    creation = <Date 2018-10-30.12:02:15.966>
    creator = 'nubirstein'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 35112
    keywords = []
    message_count = 6.0
    messages = ['328904', '328905', '328910', '328912', '328913', '328914']
    nosy_count = 2.0
    nosy_names = ['xtreak', 'nubirstein']
    pr_nums = []
    priority = 'normal'
    resolution = 'duplicate'
    stage = 'resolved'
    status = 'closed'
    superseder = '26175'
    type = 'behavior'
    url = 'https://bugs.python.org/issue35112'
    versions = ['Python 3.7']

    @nubirstein
    Copy link
    Mannequin Author

    nubirstein mannequin commented Oct 30, 2018

    Although seekable() method is implemented in the IOBase (which means it is callable in BytesIO and StringIO), SpooledTemporaryFile class from lib/tempfile.py still does not implement it.

    @nubirstein nubirstein mannequin added 3.7 (EOL) end of life stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Oct 30, 2018
    @tirkarthi
    Copy link
    Member

    Thanks for the report. Search gives me a related issue with PR to implement IOBase for SpooledTemporaryFile : bpo-26175

    @nubirstein
    Copy link
    Mannequin Author

    nubirstein mannequin commented Oct 30, 2018

    Should I have been added my request there? Anyway I do suffer from lack of 'seekable()' implementation there. I'll go there and make a request

    @tirkarthi
    Copy link
    Member

    The related issue already implements seekable and other methods for IOBase. As I can see from the open PR there are PR comments with respect to tests and docs that need to be acted upon as per reviewer's comments. With respect to this issue I propose closing this as a duplicate with bpo-26175 as superseder to continue your discussion there where it might be useful.

    Thanks!

    @nubirstein
    Copy link
    Mannequin Author

    nubirstein mannequin commented Oct 30, 2018

    According to Karthikeyan request I'am moving this discussion to the right place, i.e. https://bugs.python.org/issue26175
    I hope to get some help there. Thx Karthikeyan for such a short response time.

    @nubirstein nubirstein mannequin closed this as completed Oct 30, 2018
    @tirkarthi
    Copy link
    Member

    @nubirstein You're welcome :) As noted in https://bugs.python.org/issue26175#msg328911 the PR has the implementation of seekable at https://github.com/python/cpython/pull/3249/files#diff-34b2145d7fe189e893ec7934afe9829cR761 . You can help with the PR reviews if any and hopefully it gets merged.

    Adding 26175 as superseder.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant