Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning.warn messages with spacing issues #79309

Closed
scorphus mannequin opened this issue Oct 31, 2018 · 9 comments
Closed

warning.warn messages with spacing issues #79309

scorphus mannequin opened this issue Oct 31, 2018 · 9 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@scorphus
Copy link
Mannequin

scorphus mannequin commented Oct 31, 2018

BPO 35128
Nosy @serhiy-storchaka, @scorphus
PRs
  • bpo-35128: Fix spacing issues in warning.warn messages #10268
  • [3.7] bpo-35128: Fix spacing issues in warning.warn() messages. (GH-10268). #10280
  • [3.6] bpo-35128: Fix spacing issues in warning.warn() messages. (GH-10268). #10281
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-11-01.12:24:14.162>
    created_at = <Date 2018-10-31.21:47:42.142>
    labels = ['3.7', '3.8', 'type-bug', 'library']
    title = 'warning.warn messages with spacing issues'
    updated_at = <Date 2018-11-01.16:27:34.692>
    user = 'https://github.com/scorphus'

    bugs.python.org fields:

    activity = <Date 2018-11-01.16:27:34.692>
    actor = 'scorphus'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-11-01.12:24:14.162>
    closer = 'serhiy.storchaka'
    components = ['Library (Lib)']
    creation = <Date 2018-10-31.21:47:42.142>
    creator = 'scorphus'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 35128
    keywords = ['patch']
    message_count = 9.0
    messages = ['329016', '329017', '329044', '329049', '329051', '329055', '329056', '329057', '329077']
    nosy_count = 2.0
    nosy_names = ['serhiy.storchaka', 'scorphus']
    pr_nums = ['10268', '10280', '10281']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue35128'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

    @scorphus
    Copy link
    Mannequin Author

    scorphus mannequin commented Oct 31, 2018

    Some warn messages miss space between words, such as:

    Use of 'buffering' argument is deprecated and ignoredsince Python 3.0.

    in bz2 library, and:

    keyfile and certfile are deprecated, use acustom context instead

    in many libraries, such as poplib and smtplib.

    Other warn messages contain too much spaces between words, such as:

    The 'filename' attribute will be removed in future versions. Use 'source' instead.

    in configparser library.

    I'm not sure if such issues affect older versions of Python. I might need help on that.

    @scorphus scorphus mannequin added 3.7 (EOL) end of life 3.8 only security fixes labels Oct 31, 2018
    @scorphus
    Copy link
    Mannequin Author

    scorphus mannequin commented Oct 31, 2018

    Sorry, only when creating the PR I read that trivial changes like this need no issue.

    @scorphus scorphus mannequin closed this as completed Oct 31, 2018
    @serhiy-storchaka
    Copy link
    Member

    I think double space after a period is not a bug.

    @serhiy-storchaka serhiy-storchaka added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Nov 1, 2018
    @scorphus
    Copy link
    Mannequin Author

    scorphus mannequin commented Nov 1, 2018

    You have a point. They make the message more readable. I've readded the double spaces.

    @serhiy-storchaka
    Copy link
    Member

    New changeset 4b5e62d by Serhiy Storchaka (Pablo Aguiar) in branch 'master':
    bpo-35128: Fix spacing issues in warning.warn() messages. (GH-10268)
    4b5e62d

    @serhiy-storchaka
    Copy link
    Member

    New changeset 5e0537c by Serhiy Storchaka in branch '3.7':
    [3.7] bpo-35128: Fix spacing issues in warning.warn() messages. (GH-10268). (GH-10280)
    5e0537c

    @serhiy-storchaka
    Copy link
    Member

    New changeset 89138f2 by Serhiy Storchaka in branch '3.6':
    [3.6] bpo-35128: Fix spacing issues in warning.warn() messages. (GH-10268). (GH-10281)
    89138f2

    @serhiy-storchaka
    Copy link
    Member

    Seems 2.7 is not affected.

    @scorphus
    Copy link
    Mannequin Author

    scorphus mannequin commented Nov 1, 2018

    Thanks again for reviewing, merging and backporting. Next time I'll try and backport as well :-)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant