Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd.complete does not handle cmd=None #79451

Open
blueyed mannequin opened this issue Nov 17, 2018 · 2 comments
Open

Cmd.complete does not handle cmd=None #79451

blueyed mannequin opened this issue Nov 17, 2018 · 2 comments
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@blueyed
Copy link
Mannequin

blueyed mannequin commented Nov 17, 2018

BPO 35270
Nosy @blueyed, @iritkatriel
PRs
  • bpo-35270: Cmd.complete: use completedefault also with cmd=None #10588
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2018-11-17.23:06:01.739>
    labels = ['3.8', 'type-bug', 'library']
    title = 'Cmd.complete does not handle cmd=None'
    updated_at = <Date 2021-09-07.14:24:40.604>
    user = 'https://github.com/blueyed'

    bugs.python.org fields:

    activity = <Date 2021-09-07.14:24:40.604>
    actor = 'iritkatriel'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2018-11-17.23:06:01.739>
    creator = 'blueyed'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 35270
    keywords = ['patch']
    message_count = 2.0
    messages = ['330035', '401285']
    nosy_count = 2.0
    nosy_names = ['blueyed', 'iritkatriel']
    pr_nums = ['10588']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue35270'
    versions = ['Python 3.8']

    @blueyed
    Copy link
    Mannequin Author

    blueyed mannequin commented Nov 17, 2018

    When parseline returns None for cmd (like pdb++ might cause it when changing a cmd "disable" to "!disable"), the following will cause a TypeError:

    compfunc = getattr(self, 'complete_' + cmd)

    "None" should be also forwarded to "completedefault", just like cmd="".

    @blueyed blueyed mannequin added type-crash A hard crash of the interpreter, possibly with a core dump 3.8 only security fixes stdlib Python modules in the Lib dir labels Nov 17, 2018
    @iritkatriel
    Copy link
    Member

    Changing type since crash is typically used for a segfault rather than an exception.

    @iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error and removed type-crash A hard crash of the interpreter, possibly with a core dump labels Sep 7, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant