Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete error handling in Python/compile.c:compiler_call() #79465

Closed
ZackerySpytz mannequin opened this issue Nov 20, 2018 · 4 comments
Closed

Incomplete error handling in Python/compile.c:compiler_call() #79465

ZackerySpytz mannequin opened this issue Nov 20, 2018 · 4 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@ZackerySpytz
Copy link
Mannequin

ZackerySpytz mannequin commented Nov 20, 2018

BPO 35284
Nosy @serhiy-storchaka, @1st1, @ZackerySpytz
PRs
  • bpo-35284: Fix the error handling in the compiler's compiler_call() #10625
  • [3.7] bpo-35284: Fix the error handling in the compiler's compiler_call(). (GH-10625) #12496
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-03-22.14:13:43.207>
    created_at = <Date 2018-11-20.22:38:01.469>
    labels = ['interpreter-core', '3.8', 'type-bug', '3.7']
    title = 'Incomplete error handling in Python/compile.c:compiler_call()'
    updated_at = <Date 2019-03-22.14:13:43.206>
    user = 'https://github.com/ZackerySpytz'

    bugs.python.org fields:

    activity = <Date 2019-03-22.14:13:43.206>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-03-22.14:13:43.207>
    closer = 'serhiy.storchaka'
    components = ['Interpreter Core']
    creation = <Date 2018-11-20.22:38:01.469>
    creator = 'ZackerySpytz'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 35284
    keywords = ['patch']
    message_count = 4.0
    messages = ['330159', '338587', '338602', '338606']
    nosy_count = 3.0
    nosy_names = ['serhiy.storchaka', 'yselivanov', 'ZackerySpytz']
    pr_nums = ['10625', '12496']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue35284'
    versions = ['Python 3.7', 'Python 3.8']

    @ZackerySpytz
    Copy link
    Mannequin Author

    ZackerySpytz mannequin commented Nov 20, 2018

    compiler_call() needs to check if an error occurred during the maybe_optimize_method_call() call.

    @ZackerySpytz ZackerySpytz mannequin added 3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Nov 20, 2018
    @brettcannon brettcannon changed the title Incomplete error handling in the compiler's compiler_call() Incomplete error handling in Python/compile.c:compiler_call() Nov 21, 2018
    @serhiy-storchaka
    Copy link
    Member

    New changeset 97f5de0 by Serhiy Storchaka (Zackery Spytz) in branch 'master':
    bpo-35284: Fix the error handling in the compiler's compiler_call(). (GH-10625)
    97f5de0

    @serhiy-storchaka
    Copy link
    Member

    New changeset bdb9c49 by Serhiy Storchaka (Zackery Spytz) in branch '3.7':
    bpo-35284: Fix the error handling in the compiler's compiler_call(). (GH-10625) (GH-12496)
    bdb9c49

    @serhiy-storchaka
    Copy link
    Member

    I wonder how did you find this bug?

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant