The repr of ctypes.CArgObject fails for non-ascii character

[serhiy-storchaka]

BPO	35384
Nosy	@amauryfa, @abalkin, @meadori, @serhiy-storchaka, @miss-islington
PRs	bpo-35384: The repr of ctypes.CArgObject no longer fail for non-ascii character. #10863 [3.7] bpo-35384: The repr of ctypes.CArgObject no longer fails for non-ascii character. (GH-10863) #10983 [3.6] bpo-35384: The repr of ctypes.CArgObject no longer fails for non-ascii character. (GH-10863) #10984 [3.7] bpo-35384: The repr of ctypes.CArgObject no longer fails for non-ascii character. (GH-10863) #10985

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-12-06.10:07:10.580>
created_at = <Date 2018-12-03.10:52:28.429>
labels = ['extension-modules', '3.8', 'ctypes', 'type-bug', '3.7']
title = 'The repr of ctypes.CArgObject fails for non-ascii character'
updated_at = <Date 2018-12-06.10:07:10.579>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2018-12-06.10:07:10.579>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-06.10:07:10.580>
closer = 'serhiy.storchaka'
components = ['Extension Modules', 'ctypes']
creation = <Date 2018-12-03.10:52:28.429>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 35384
keywords = ['patch']
message_count = 4.0
messages = ['330931', '331213', '331215', '331219']
nosy_count = 5.0
nosy_names = ['amaury.forgeotdarc', 'belopolsky', 'meador.inge', 'serhiy.storchaka', 'miss-islington']
pr_nums = ['10863', '10983', '10984', '10985']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue35384'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

[serhiy-storchaka]

The repr of the ctypes.CArgObject instance will fail when the value is a non-ascii character.

The code is:

    sprintf(buffer, "<cparam '%c' (%c)>",
        self->tag, self->value.c);
...
return PyUnicode_FromString(buffer);

If self->value.c is out of range 0-127, buffer will contain a string not decodable with UTF-8.

There is a similar problem with non-ascii self->tag.

The following PR is purposed to fix this, but I don't know how to test it. Current tests only create CArgObject instances with tag='P' (in byref()).

[serhiy-storchaka]

New changeset 3ffa8b9 by Serhiy Storchaka in branch 'master':
bpo-35384: The repr of ctypes.CArgObject no longer fails for non-ascii character. (GH-10863)
3ffa8b9

[miss-islington]

New changeset f9d8b68 by Miss Islington (bot) in branch '3.6':
bpo-35384: The repr of ctypes.CArgObject no longer fails for non-ascii character. (GH-10863)
f9d8b68

[miss-islington]

New changeset f740818 by Miss Islington (bot) in branch '3.7':
bpo-35384: The repr of ctypes.CArgObject no longer fails for non-ascii character. (GH-10863)
f740818