Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument Clinic should use "const Py_UNICODE *" for the Py_UNICODE converter #79670

Closed
serhiy-storchaka opened this issue Dec 14, 2018 · 3 comments
Assignees
Labels
3.7 (EOL) end of life 3.8 only security fixes topic-argument-clinic type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

BPO 35489
Nosy @larryhastings, @serhiy-storchaka
PRs
  • bpo-35489: Use "const Py_UNICODE *" for the Py_UNICODE converter in AC. #11150
  • [3.7] bpo-35489: Use "const Py_UNICODE *" for the Py_UNICODE converter in AC. (GH-11150). #11151
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2018-12-14.09:57:23.567>
    created_at = <Date 2018-12-14.08:53:53.451>
    labels = ['3.8', 'type-bug', '3.7', 'expert-argument-clinic']
    title = 'Argument Clinic should use "const Py_UNICODE *" for the Py_UNICODE converter'
    updated_at = <Date 2018-12-14.09:57:23.566>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2018-12-14.09:57:23.566>
    actor = 'serhiy.storchaka'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2018-12-14.09:57:23.567>
    closer = 'serhiy.storchaka'
    components = ['Argument Clinic']
    creation = <Date 2018-12-14.08:53:53.451>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 35489
    keywords = ['patch']
    message_count = 3.0
    messages = ['331787', '331789', '331792']
    nosy_count = 2.0
    nosy_names = ['larry', 'serhiy.storchaka']
    pr_nums = ['11150', '11151']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue35489'
    versions = ['Python 3.7', 'Python 3.8']

    @serhiy-storchaka
    Copy link
    Member Author

    Format units "Z" and "Z#" in PyArg_Parse* return a pointer to immutable internal data. Therefor the result of the Py_UNICODE converter in Argument Clinic should has type "const Py_UNICODE *".

    This would help to catch the bug reported in bpo-31446.

    @serhiy-storchaka serhiy-storchaka added 3.7 (EOL) end of life 3.8 only security fixes labels Dec 14, 2018
    @serhiy-storchaka serhiy-storchaka self-assigned this Dec 14, 2018
    @serhiy-storchaka serhiy-storchaka added topic-argument-clinic type-bug An unexpected behavior, bug, or error labels Dec 14, 2018
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset afb3e71 by Serhiy Storchaka in branch 'master':
    bpo-35489: Use "const Py_UNICODE *" for the Py_UNICODE converter in AC. (GH-11150)
    afb3e71

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 45a7b76 by Serhiy Storchaka in branch '3.7':
    [3.7] bpo-35489: Use "const Py_UNICODE *" for the Py_UNICODE converter in AC. (GH-11150). (GH-11151)
    45a7b76

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes topic-argument-clinic type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant