New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_builtin fails after merging the fix for bpo-34756 #79923
Comments
On git-master (32ebd85) of CPython, 3 tests of test_builtin fails: ====================================================================== Traceback (most recent call last):
File "/home/yen/Projects/cpython/Lib/test/test_builtin.py", line 1618, in test_envar_unimportable
breakpoint()
ValueError: Empty module name ====================================================================== Traceback (most recent call last):
File "/home/yen/Projects/cpython/Lib/test/test_builtin.py", line 1618, in test_envar_unimportable
breakpoint()
ValueError: Empty module name ====================================================================== Traceback (most recent call last):
File "/home/yen/Projects/cpython/Lib/test/test_builtin.py", line 1618, in test_envar_unimportable
breakpoint()
ValueError: Empty module name If I revert 6fe9c44, tests pass. This commit is from bpo-34756, so I add the author of that patch to the nosy list. Environment: Arch Linux x86_64 Steps to reproduce: |
Wow that's super fast! I can confirm the patch fixes the issue on my machine. Thanks! |
I don't understand why buildbots didn't scream and why the test didn't fail on Travis CI nor AppVeyor on #9457 |
Found a test_builtin failure in the job for the relevant commit on Travis CI - https://travis-ci.org/python/cpython/jobs/479642964#L1491. I guess it's not noticed as it's listed in allow_failures in .travis.yml. However, I'm not sure if it's the same issue or not as there are no failure details. |
This job is for code coverage. I confirm that failures are allowed. This job runs the full test suite in sequence, whereas the main Travis CI job runs tests in parallel... I tested running tests in sequence and in parallel: test_builtin fail in both cases. It's a mystery. Anyway, it's going to be fixed soon ;-) |
I was surprised too. Maybe it is because that was very old PR. |
Yeah, that's the most likely explanation. Maybe the CI ran tests before the final merge, or something like that? It doesn't explain why buildbots didn't complain, but it doesn't matter if such hiccup is very rare ;-) |
Maybe CI updates only files touched by the PR and the failed test was added after the initial creation of the PR? Or there is something wrong with timestamps, so outdated pyc files were used for tests? |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: