Typo in example for async with statement with condition

[mhchia]

BPO	35826
Nosy	@asvetlov, @1st1, @willingc, @eamanu, @mhchia
PRs	bpo-35826: Fix typo in equivalent code of async with cond #11681 bpo-35826: Fix typo in equivalent code of async with cond #11681 bpo-35826: Fix typo in equivalent code of async with cond #11681 bpo-35826: Fix typo in equivalent code of async with cond #11681 [3.7] bpo-35826: Fix typo: equivalent code of async with cond (GH-11681) #16720

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-02-22.14:44:26.230>
created_at = <Date 2019-01-25.10:44:12.895>
labels = ['easy', 'type-feature', '3.8', 'expert-asyncio']
title = 'Typo in example for async with statement with condition'
updated_at = <Date 2019-10-11.17:24:08.075>
user = 'https://github.com/mhchia'

bugs.python.org fields:

activity = <Date 2019-10-11.17:24:08.075>
actor = 'miss-islington'
assignee = 'docs@python'
closed = True
closed_date = <Date 2019-02-22.14:44:26.230>
closer = 'mhchia'
components = ['asyncio']
creation = <Date 2019-01-25.10:44:12.895>
creator = 'mhchia'
dependencies = []
files = []
hgrepos = []
issue_num = 35826
keywords = ['patch', 'patch', 'patch', 'patch', 'easy']
message_count = 5.0
messages = ['334349', '334350', '334376', '336310', '336318']
nosy_count = 6.0
nosy_names = ['asvetlov', 'docs@python', 'yselivanov', 'willingc', 'eamanu', 'mhchia']
pr_nums = ['11681', '11681', '11681', '11681', '16720']
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue35826'
versions = ['Python 3.8']

[mhchia]

In the example of the equivalent code to the async with statement:

cond = asyncio.Condition()

# ... later
await lock.acquire()
try:
    await cond.wait()
finally:
    lock.release()

lock.acquire() should be replaced by cond.acquire(), and lock.release() replaced by cond.release(). So the resulting code snippet becomes:

cond = asyncio.Condition()

# ... later
await cond.acquire()
try:
    await cond.wait()
finally:
    cond.release()

[mhchia]

In the example of the equivalent code to the async with statement:

cond = asyncio.Condition()

# ... later
await lock.acquire()
try:
    await cond.wait()
finally:
    lock.release()

lock.acquire() should be replaced by cond.acquire(), and lock.release() replaced by cond.release(). So the resulting code snippet becomes:

cond = asyncio.Condition()

# ... later
await cond.acquire()
try:
    await cond.wait()
finally:
    cond.release()

[1st1]

Please submit a PR!

[eamanu]

This issue could be closed, right?

[mhchia]

Cool! Thanks for the reminder.