Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added thousands separators to Lib/pstats.py final report #80030

Open
addonszz mannequin opened this issue Jan 29, 2019 · 3 comments
Open

Added thousands separators to Lib/pstats.py final report #80030

addonszz mannequin opened this issue Jan 29, 2019 · 3 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@addonszz
Copy link
Mannequin

addonszz mannequin commented Jan 29, 2019

BPO 35849
Nosy @csabella, @addonszz
PRs
  • bpo-35849: Added thousands separators to Lib/pstats.py final report #11695
  • bpo-35849: Added thousands separators to Lib/pstats.py final report #11695
  • bpo-35849: Added thousands separators to Lib/pstats.py final report #11695
  • gh-80030: Added thousands separators to Lib/pstats.py final report #13411
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2019-01-29.12:52:11.441>
    labels = ['3.8', 'type-feature', 'library']
    title = 'Added thousands separators to Lib/pstats.py final report'
    updated_at = <Date 2019-06-01.12:02:14.647>
    user = 'https://github.com/addonszz'

    bugs.python.org fields:

    activity = <Date 2019-06-01.12:02:14.647>
    actor = 'cheryl.sabella'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2019-01-29.12:52:11.441>
    creator = 'addons_zz'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 35849
    keywords = ['patch', 'patch', 'patch']
    message_count = 3.0
    messages = ['334513', '334522', '344169']
    nosy_count = 3.0
    nosy_names = ['SilentGhost', 'cheryl.sabella', 'addons_zz']
    pr_nums = ['11695', '11695', '11695', '13411']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue35849'
    versions = ['Python 3.8']

    @addonszz
    Copy link
    Mannequin Author

    addonszz mannequin commented Jan 29, 2019

    Instead of doing:

             10056.0 function calls in 0.006 seconds
    
       Ordered by: internal time
    
       ncalls  tottime  percall  cumtime  percall filename:lineno(function)
         1.0    0.002    0.002    0.006    0.006 benchmark_tests.py:121(logging_mod_log_debuglog_off)
      5000.0    0.002    0.000    0.004    0.000 F:\Python\lib\logging\__init__.py:1362(debug)
      5000.0    0.001    0.000    0.001    0.000 F:\Python\lib\logging\__init__.py:1620(isEnabledFor)
    

    Do:

             10,056.0 function calls in 0.006 seconds
    
       Ordered by: internal time
    
       ncalls  tottime  percall  cumtime  percall filename:lineno(function)
          1.0    0.002    0.002    0.006    0.006 benchmark_tests.py:121(logging_mod_log_debuglog_off)
      5,000.0    0.002    0.000    0.004    0.000 F:\Python\lib\logging\__init__.py:1362(debug)
      5,000.0    0.001    0.000    0.001    0.000 F:\Python\lib\logging\__init__.py:1620(isEnabledFor)
    

    @addonszz addonszz mannequin added 3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Jan 29, 2019
    @SilentGhost
    Copy link
    Mannequin

    SilentGhost mannequin commented Jan 29, 2019

    Hi, your change breaks some test, most of the breakage is related to the change in whitespace separators. This breakages should be fixed before your PR can be considered for inclusion. You can see the status of the tests within discussion on github.

    @csabella
    Copy link
    Contributor

    csabella commented Jun 1, 2019

    For reference, bpo-24084 is about increasing the size of the quicker timings. Both projects change the layout.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @arhadthedev arhadthedev removed the 3.8 only security fixes label Apr 25, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants