Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of NamedStore #80368

Closed
serhiy-storchaka opened this issue Mar 4, 2019 · 2 comments
Closed

Get rid of NamedStore #80368

serhiy-storchaka opened this issue Mar 4, 2019 · 2 comments
Labels
3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@serhiy-storchaka
Copy link
Member

BPO 36187
Nosy @gvanrossum, @tim-one, @serhiy-storchaka, @MojoVampire, @emilyemorehouse
PRs
  • bpo-36187: Remove NamedStore. #12167
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-03-05.18:57:36.405>
    created_at = <Date 2019-03-04.16:10:00.443>
    labels = ['interpreter-core', '3.8']
    title = 'Get rid of NamedStore'
    updated_at = <Date 2019-03-05.18:57:36.405>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2019-03-05.18:57:36.405>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-03-05.18:57:36.405>
    closer = 'serhiy.storchaka'
    components = ['Interpreter Core']
    creation = <Date 2019-03-04.16:10:00.443>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36187
    keywords = ['patch']
    message_count = 2.0
    messages = ['337136', '337236']
    nosy_count = 5.0
    nosy_names = ['gvanrossum', 'tim.peters', 'serhiy.storchaka', 'josh.r', 'emilyemorehouse']
    pr_nums = ['12167']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue36187'
    versions = ['Python 3.8']

    @serhiy-storchaka
    Copy link
    Member Author

    The proposed PR refactors the code for assignment expression and removes the NamedStore value of the expr_context_ty enum added in bpo-35224. This value is undistinguished from Store except two places in Python/ast.c and Python/symtable.c, but in that cases the difference can be handled at one level upper (when process the NamedExpr expression).

    As a side effect this PR fixes the following minor bug:

    >>> (True := 1)
      File "<stdin>", line 1
    SyntaxError: cannot delete True

    @serhiy-storchaka serhiy-storchaka added 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Mar 4, 2019
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset d8b3a98 by Serhiy Storchaka in branch 'master':
    bpo-36187: Remove NamedStore. (GH-12167)
    d8b3a98

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant