Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Travis CI config to Xenial from near-EoL Trusty and remove obsolete sudo: false key #80488

Closed
CAM-Gerlach opened this issue Mar 15, 2019 · 14 comments
Labels
build The build process and cross-build

Comments

@CAM-Gerlach
Copy link
Member

BPO 36307
Nosy @vstinner, @methane, @zware, @matrixise, @pablogsal, @tirkarthi, @CAM-Gerlach
PRs
  • bpo-36307: Upgrade Travis CI to Xenial and rm obsolete sudo:false #12356
  • [2.7] bpo-36307: Travis: upgrade to Xenial environment (GH-12356) #12404
  • [3.7] bpo-36307: Travis: upgrade to Xenial environment (GH-12356) #12405
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-03-19.09:11:40.769>
    created_at = <Date 2019-03-15.19:43:52.397>
    labels = ['build']
    title = 'Upgrade Travis CI config to Xenial from near-EoL Trusty and remove obsolete sudo: false key'
    updated_at = <Date 2019-03-19.09:11:40.769>
    user = 'https://github.com/CAM-Gerlach'

    bugs.python.org fields:

    activity = <Date 2019-03-19.09:11:40.769>
    actor = 'methane'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-03-19.09:11:40.769>
    closer = 'methane'
    components = ['Build']
    creation = <Date 2019-03-15.19:43:52.397>
    creator = 'CAM-Gerlach'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36307
    keywords = ['patch']
    message_count = 14.0
    messages = ['338022', '338023', '338025', '338038', '338041', '338047', '338048', '338194', '338201', '338203', '338206', '338218', '338328', '338334']
    nosy_count = 7.0
    nosy_names = ['vstinner', 'methane', 'zach.ware', 'matrixise', 'pablogsal', 'xtreak', 'CAM-Gerlach']
    pr_nums = ['12356', '12404', '12405']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue36307'
    versions = []

    @CAM-Gerlach
    Copy link
    Member Author

    Not sure how to categorize this one, or if this should even be a bpo.

    Currently, the .travis.yml config file still has a sudo: false key, which previously triggered the Container-based environment on Travis. However, that was removed in December 2018, and so the key is now obsolete. Furthermore, the builds are still running in the Trusty environment, which will be at the end of its 5-year development lifecycle in April 2019 (next month). Therefore, sudo: false should be removed, and the distribution should be upgraded to the modern dist: xenial.

    If non-trivial errors result, the change will likely be well beyond my minimal expertise as a brand-new contributor, but I figured I'd nevertheless make the attempt in a PR if not, which others can take over/supersede if necessary.

    @matrixise
    Copy link
    Member

    Hi @Cam, do you have a pointer about the deprecated/removed feature in Travis?

    Thank you

    @CAM-Gerlach
    Copy link
    Member Author

    Sure, thing, sorry—I realized I should have added one but apparently couldn't edit my post to include it.

    Here's a description of the removal of the obsolete sudo: false key in the Travis docs, and here's a blog post on the imminent EoL of Trusty Tar.

    @tirkarthi
    Copy link
    Member

    This changes the Ubuntu version in Travis so I would like this decision to be reviewed by core devs who work more closely with buildbot and configs.

    @CAM-Gerlach
    Copy link
    Member Author

    Yes, absolutely.

    While were at it, should we also bump the OpenSSL version up to the latest 1.1.1b, which is the current LTS branch (with 1.0.2 EoL in Dec. 2019 and 1.1.0 EoL in a few months, in September)?

    @CAM-Gerlach CAM-Gerlach added the build The build process and cross-build label Mar 15, 2019
    @tirkarthi
    Copy link
    Member

    There is an open issue with PR for openssl upgrade . Please see https://bugs.python.org/issue34631

    @CAM-Gerlach
    Copy link
    Member Author

    Ah yes, I actually saw that before opening this issue; not sure why I completely forgot about it. Sorry about that and thanks for the reminder.

    @methane
    Copy link
    Member

    methane commented Mar 18, 2019

    New changeset 74ae50e by Inada Naoki (CAM Gerlach) in branch 'master':
    bpo-36307: Travis: upgrade to Xenial environment (GH-12356)
    74ae50e

    @vstinner
    Copy link
    Member

    INADA-san: I would prefer to use the same OS to test Python 2.7 and 3.7. Are you ok to backport this change? (if it didn't break the CI yet? :-))

    @methane
    Copy link
    Member

    methane commented Mar 18, 2019

    Ah, miss-islington is still broken...

    I'll create backport PR manually if travis succeed to build master branch.
    https://travis-ci.org/python/cpython/builds/507808242

    @vstinner
    Copy link
    Member

    Ah, miss-islington is still broken...

    Right: python/miss-islington#219

    @methane
    Copy link
    Member

    methane commented Mar 18, 2019

    https://travis-ci.org/python/cpython/jobs/507821992
    "pyenv: python3.7: command not found"

    Hmm, dist: xenial; group beta seems not stable yet.
    I'll try removing "group: beta" for stable build.

    @methane
    Copy link
    Member

    methane commented Mar 19, 2019

    New changeset 09e5877 by Inada Naoki in branch '3.7':
    bpo-36307: Travis: upgrade to Xenial environment (GH-12356)
    09e5877

    @methane
    Copy link
    Member

    methane commented Mar 19, 2019

    New changeset 0f68d4a by Inada Naoki in branch '2.7':
    bpo-36307: Travis: upgrade to Xenial environment (GH-12356)
    0f68d4a

    @methane methane closed this as completed Mar 19, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build
    Projects
    None yet
    Development

    No branches or pull requests

    5 participants