Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in documentation of _PyObject_FastCallDict #80498

Closed
remilapeyre mannequin opened this issue Mar 16, 2019 · 3 comments
Closed

Typo in documentation of _PyObject_FastCallDict #80498

remilapeyre mannequin opened this issue Mar 16, 2019 · 3 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@remilapeyre
Copy link
Mannequin

remilapeyre mannequin commented Mar 16, 2019

BPO 36317
Nosy @vstinner, @remilapeyre
PRs
  • bpo-36317: Fix typo in _PyObject_FastCallDict documentation #12383
  • [3.7] bpo-36317: Fix typo in _PyObject_FastCallDict documentation #12402
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-03-18.11:53:19.126>
    created_at = <Date 2019-03-16.15:03:49.047>
    labels = ['interpreter-core', '3.7', '3.8']
    title = 'Typo in documentation of _PyObject_FastCallDict'
    updated_at = <Date 2019-03-18.11:53:19.124>
    user = 'https://github.com/remilapeyre'

    bugs.python.org fields:

    activity = <Date 2019-03-18.11:53:19.124>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-03-18.11:53:19.126>
    closer = 'vstinner'
    components = ['Interpreter Core']
    creation = <Date 2019-03-16.15:03:49.047>
    creator = 'remi.lapeyre'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36317
    keywords = ['patch']
    message_count = 3.0
    messages = ['338085', '338204', '338205']
    nosy_count = 2.0
    nosy_names = ['vstinner', 'remi.lapeyre']
    pr_nums = ['12383', '12402']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue36317'
    versions = ['Python 3.7', 'Python 3.8']

    @remilapeyre
    Copy link
    Mannequin Author

    remilapeyre mannequin commented Mar 16, 2019

    Return result is documented as:

    Return the result on success. Raise an exception on return NULL on error.

    I'm not absolutely sure but shouldn't that be "Raise an exception and return NULL on error."?

    Or should it be "Raise an exception or return NULL on error."?

    @remilapeyre remilapeyre mannequin added 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Mar 16, 2019
    @vstinner
    Copy link
    Member

    New changeset 67294f6 by Victor Stinner (Rémi Lapeyre) in branch '3.7':
    bpo-36317: Fix typo in _PyObject_FastCallDict documentation (GH-12383) (GH-12402)
    67294f6

    @vstinner
    Copy link
    Member

    #12383 has been merged into master:

    commit b4b97af
    Author: Rémi Lapeyre <remi.lapeyre@henki.fr>
    Date: Mon Mar 18 11:07:53 2019 +0100

    Fix typo in _PyObject_FastCallDict documentation (GH-12383)
    

    Thanks Rémi Lapeyre.

    @vstinner vstinner added the 3.7 (EOL) end of life label Mar 18, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant