Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out / add bdb.Bdb.is_skipped_frame #80516

Open
blueyed mannequin opened this issue Mar 18, 2019 · 1 comment
Open

Factor out / add bdb.Bdb.is_skipped_frame #80516

blueyed mannequin opened this issue Mar 18, 2019 · 1 comment
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@blueyed
Copy link
Mannequin

blueyed mannequin commented Mar 18, 2019

BPO 36335
Nosy @blueyed
PRs
  • bpo-36335: add bdb.Bdb.is_skipped_frame #12392
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2019-03-18.03:30:29.652>
    labels = ['3.8', 'type-feature', 'library']
    title = 'Factor out / add bdb.Bdb.is_skipped_frame'
    updated_at = <Date 2019-03-18.03:31:28.370>
    user = 'https://github.com/blueyed'

    bugs.python.org fields:

    activity = <Date 2019-03-18.03:31:28.370>
    actor = 'blueyed'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2019-03-18.03:30:29.652>
    creator = 'blueyed'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36335
    keywords = ['patch']
    message_count = 1.0
    messages = ['338159']
    nosy_count = 1.0
    nosy_names = ['blueyed']
    pr_nums = ['12392']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue36335'
    versions = ['Python 3.8']

    @blueyed
    Copy link
    Mannequin Author

    blueyed mannequin commented Mar 18, 2019

    In https://bugs.python.org/issue36130 is_skipped_module was changed to handle frames without __name__, but I think it makes sense being able to skip e.g. frames on frame.f_code.co_name then.

    Factoring out is_skipped_frame allows for this.

    The default implementation would call is_skipped_module if there are any skip patterns, and return False otherwise.

    @blueyed blueyed mannequin added 3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Mar 18, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants