Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elif sentence on to avoid multiple if #80566

Closed
eamanu mannequin opened this issue Mar 21, 2019 · 3 comments
Closed

Add elif sentence on to avoid multiple if #80566

eamanu mannequin opened this issue Mar 21, 2019 · 3 comments
Labels
3.8 only security fixes type-bug An unexpected behavior, bug, or error

Comments

@eamanu
Copy link
Mannequin

eamanu mannequin commented Mar 21, 2019

BPO 36385
Nosy @rhettinger, @eamanu, @miss-islington
PRs
  • bpo-36385: Add elif sentence on to avoid multiple if #12478
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-03-21.04:39:50.741>
    created_at = <Date 2019-03-21.01:44:32.032>
    labels = ['type-bug', '3.8']
    title = 'Add ``elif`` sentence on to avoid multiple ``if``'
    updated_at = <Date 2019-03-21.04:39:50.737>
    user = 'https://github.com/eamanu'

    bugs.python.org fields:

    activity = <Date 2019-03-21.04:39:50.737>
    actor = 'rhettinger'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-03-21.04:39:50.741>
    closer = 'rhettinger'
    components = []
    creation = <Date 2019-03-21.01:44:32.032>
    creator = 'eamanu'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36385
    keywords = ['patch']
    message_count = 3.0
    messages = ['338519', '338523', '338524']
    nosy_count = 3.0
    nosy_names = ['rhettinger', 'eamanu', 'miss-islington']
    pr_nums = ['12478']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue36385'
    versions = ['Python 3.8']

    @eamanu
    Copy link
    Mannequin Author

    eamanu mannequin commented Mar 21, 2019

    Currently, when arguments on Parser/asdl_c.py are parsed
    ìf sentence is used. This PR(#12478) Propose to use elif
    to avoid multiple evaluting of the ifs.

    @eamanu eamanu mannequin added 3.8 only security fixes type-bug An unexpected behavior, bug, or error labels Mar 21, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset ed5e29c by Miss Islington (bot) (Emmanuel Arias) in branch 'master':
    bpo-36385: Add elif sentence on to avoid multiple if (GH-12478)
    ed5e29c

    @rhettinger
    Copy link
    Contributor

    Thanks for the patch.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants