Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telnetlib process_rawq() callback #80662

Closed
goztrk mannequin opened this issue Mar 30, 2019 · 6 comments
Closed

telnetlib process_rawq() callback #80662

goztrk mannequin opened this issue Mar 30, 2019 · 6 comments
Labels
3.11 only security fixes topic-IO type-feature A feature request or enhancement

Comments

@goztrk
Copy link
Mannequin

goztrk mannequin commented Mar 30, 2019

BPO 36481
Nosy @giampaolo, @goztrk
PRs
  • bpo-36481: Adding callback to fill_rawq #12623
  • bpo-36481: Added callback to telnetlib so that incoming data can be decompressed before processes #29052
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2019-03-30.02:11:13.505>
    labels = ['type-feature', 'expert-IO', '3.11']
    title = 'telnetlib process_rawq() callback'
    updated_at = <Date 2021-10-20.23:14:20.441>
    user = 'https://github.com/goztrk'

    bugs.python.org fields:

    activity = <Date 2021-10-20.23:14:20.441>
    actor = 'goztrk'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['IO']
    creation = <Date 2019-03-30.02:11:13.505>
    creator = 'goztrk'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36481
    keywords = ['patch']
    message_count = 3.0
    messages = ['339166', '339383', '404272']
    nosy_count = 3.0
    nosy_names = ['giampaolo.rodola', 'SilentGhost', 'goztrk']
    pr_nums = ['12623', '29052']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue36481'
    versions = ['Python 3.11']

    @goztrk
    Copy link
    Mannequin Author

    goztrk mannequin commented Mar 30, 2019

    telnetlib.Telnet class requires a callback so that the raw data that comes from socket can be processed first.

    This will be useful for the compressed incoming data. Most of the MUD servers have MCCP V2 (byte: 86) protocol that send compressed data. But as for now. the only option is to create new class that inherits telnetlib.Telnet and override process_rawq()

    @goztrk goztrk mannequin added 3.7 (EOL) end of life topic-IO type-feature A feature request or enhancement labels Mar 30, 2019
    @SilentGhost
    Copy link
    Mannequin

    SilentGhost mannequin commented Apr 3, 2019

    As a general rule, your PR would have to include documentation (including a NEWS entry) and tests for the new functionality. Naturally, by itself it's not a guarantee that this suggestion would be accepted.

    @SilentGhost SilentGhost mannequin added 3.8 only security fixes and removed 3.7 (EOL) end of life labels Apr 3, 2019
    @goztrk
    Copy link
    Mannequin Author

    goztrk mannequin commented Oct 19, 2021

    Made updates, tests for this old issue.

    @goztrk goztrk mannequin added 3.11 only security fixes and removed 3.8 only security fixes labels Oct 20, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @hugovk
    Copy link
    Member

    hugovk commented Apr 12, 2022

    Note the telnetlib module is deprecated in 3.11 and set for removal in 3.13.

    See PEP 594 – Removing dead batteries from the standard library and #91217.

    @hugovk
    Copy link
    Member

    hugovk commented Apr 12, 2022

    Closing like the PR, due to deprecation: #29052 (comment)

    @hugovk hugovk closed this as completed Apr 12, 2022
    @AlexWaygood
    Copy link
    Member

    Closing like the PR, due to deprecation: #29052 (comment)

    Cc. @giampaolo, @goztrk

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 only security fixes topic-IO type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants