race in logging code when fork()

[cagney]

BPO	36587
Nosy	@gpshead, @vsajip, @cagney
Files	btc.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gpshead'
closed_at = <Date 2019-09-24.21:58:30.902>
created_at = <Date 2019-04-10.14:14:38.663>
labels = ['3.7', 'type-bug', 'library']
title = 'race in logging code when fork()'
updated_at = <Date 2019-09-24.21:58:30.894>
user = 'https://github.com/cagney'

bugs.python.org fields:

activity = <Date 2019-09-24.21:58:30.894>
actor = 'gregory.p.smith'
assignee = 'gregory.p.smith'
closed = True
closed_date = <Date 2019-09-24.21:58:30.902>
closer = 'gregory.p.smith'
components = ['Library (Lib)']
creation = <Date 2019-04-10.14:14:38.663>
creator = 'cagney'
dependencies = []
files = ['48258']
hgrepos = []
issue_num = 36587
keywords = []
message_count = 4.0
messages = ['339866', '339880', '352999', '353119']
nosy_count = 3.0
nosy_names = ['gregory.p.smith', 'vinay.sajip', 'cagney']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue36587'
versions = ['Python 3.7']

[cagney]

Buried in bpo-36533; it should probably be turned into a test case.

Exception ignored in: <function _after_at_fork_weak_calls at 0x7f7307550378>
Traceback (most recent call last):
  File "/home/python/v3.7.3/lib/python3.7/logging/__init__.py", line
269, in _after_at_fork_weak_calls
    _at_fork_weak_calls('release')
  File "/home/python/v3.7.3/lib/python3.7/logging/__init__.py", line
254, in _at_fork_weak_calls
    for instance in _at_fork_acquire_release_weakset:
  File "/home/python/v3.7.3/lib/python3.7/_weakrefset.py", line 60, in __iter__
    for itemref in self.data:
RuntimeError: Set changed size during iteration

Exception in thread Thread-1:
Traceback (most recent call last):
  File "/home/python/v3.7.3/lib/python3.7/threading.py", line 917, in
_bootstrap_inner
    self.run()
  File "/home/python/v3.7.3/lib/python3.7/threading.py", line 865, in run
    self._target(*self._args, **self._kwargs)
  File "./btc.py", line 11, in lockie
    h = logging.Handler()
  File "/home/python/v3.7.3/lib/python3.7/logging/__init__.py", line
824, in __init__
    self.createLock()
  File "/home/python/v3.7.3/lib/python3.7/logging/__init__.py", line
847, in createLock
    _register_at_fork_acquire_release(self)
  File "/home/python/v3.7.3/lib/python3.7/logging/__init__.py", line
250, in _register_at_fork_acquire_release
    _at_fork_acquire_release_weakset.add(instance)
  File "/home/python/v3.7.3/lib/python3.7/_weakrefset.py", line 83, in add
    self._commit_removals()
  File "/home/python/v3.7.3/lib/python3.7/_weakrefset.py", line 56, in
_commit_removals
    discard(l.pop())
IndexError: pop from empty list

[gpshead]

yeah i saw that bug buried in there, this weakset goes away with my proposed PR.

[vsajip]

Is this issue still valid, or should it be closed as out of date?

[gpshead]

i don't have context for what test was needed where anymore, but #12704 removed the _at_fork_acquire_release_weakset.