should pty.openpty() set pty/tty inheritable?

[cagney]

BPO	36603
Nosy	@Yhg1s, @cagney

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2019-04-11.15:17:03.564>
labels = ['3.7', 'expert-IO']
title = 'should pty.openpty() set pty/tty inheritable?'
updated_at = <Date 2019-04-11.16:20:58.800>
user = 'https://github.com/cagney'

bugs.python.org fields:

activity = <Date 2019-04-11.16:20:58.800>
actor = 'hugh'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['IO']
creation = <Date 2019-04-11.15:17:03.564>
creator = 'cagney'
dependencies = []
files = []
hgrepos = []
issue_num = 36603
keywords = []
message_count = 1.0
messages = ['339982']
nosy_count = 3.0
nosy_names = ['twouters', 'cagney', 'hugh']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue36603'
versions = ['Python 3.7']

[cagney]

pty.openpty(), on systems with a working os.openpty() / openpty(3) executes:

if (openpty(&master_fd, &slave_fd, NULL, NULL, NULL) != 0)
    goto posix_error;
if (_Py_set_inheritable(master_fd, 0, NULL) < 0)
    goto error;
if (_Py_set_inheritable(slave_fd, 0, NULL) < 0)
    goto error;

where as on systems where this is fails it instead executes:

master_fd, slave_name = _open_terminal()
slave_fd = slave_open(slave_name)
    i.e., result = os.open(tty_name, os.O_RDWR)
return master_fd, slave_fd

where os.open() was "Changed in version 3.4: The new file descriptor is now non-inheritable."

(personally I'd deprecate pty.openpty(), but that is just me)