Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A typing error in demo rpython.py #80871

Closed
brifuture mannequin opened this issue Apr 21, 2019 · 5 comments
Closed

A typing error in demo rpython.py #80871

brifuture mannequin opened this issue Apr 21, 2019 · 5 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes easy type-bug An unexpected behavior, bug, or error

Comments

@brifuture
Copy link
Mannequin

brifuture mannequin commented Apr 21, 2019

BPO 36690
Nosy @gvanrossum, @berkerpeksag, @BriFuture
PRs
  • bpo-36690: Fix typing error in demo rpython.py #12903
  • [3.7] bpo-36690: Fix typo in Tools/demo/rpython.py (GH-12903) #12906
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-04-22.13:54:38.495>
    created_at = <Date 2019-04-21.12:52:55.381>
    labels = ['easy', '3.8', 'type-bug', '3.7']
    title = 'A typing error in demo rpython.py'
    updated_at = <Date 2019-04-22.13:54:38.494>
    user = 'https://github.com/brifuture'

    bugs.python.org fields:

    activity = <Date 2019-04-22.13:54:38.494>
    actor = 'berker.peksag'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-04-22.13:54:38.495>
    closer = 'berker.peksag'
    components = ['Demos and Tools']
    creation = <Date 2019-04-21.12:52:55.381>
    creator = 'jiawei zhou'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36690
    keywords = ['patch', 'easy']
    message_count = 5.0
    messages = ['340606', '340609', '340651', '340653', '340654']
    nosy_count = 4.0
    nosy_names = ['gvanrossum', 'SilentGhost', 'berker.peksag', 'jiawei zhou']
    pr_nums = ['12903', '12906']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue36690'
    versions = ['Python 3.7', 'Python 3.8']

    @brifuture
    Copy link
    Mannequin Author

    brifuture mannequin commented Apr 21, 2019

    Hi. There is an error in file [Tools/demo/rpython.py](https://github.com/python/cpython/blob/main/Tools/demo/rpython.py) at line 22.
    The original statement is port = int(port[i+1:]), but it will crash if the port is specified as parameters.
    The correct code should be port = int(host[i+1:]). Then the program can read specified port from parameter sys.argv[1].

    @brifuture brifuture mannequin added the type-crash A hard crash of the interpreter, possibly with a core dump label Apr 21, 2019
    @SilentGhost
    Copy link
    Mannequin

    SilentGhost mannequin commented Apr 21, 2019

    Would you be interested in submitting a PR on github? Guidelines can be found on https://devguide.python.org/pullrequest/ if you're not sure how to proceed.

    @SilentGhost SilentGhost mannequin added 3.7 (EOL) end of life 3.8 only security fixes type-bug An unexpected behavior, bug, or error easy and removed type-crash A hard crash of the interpreter, possibly with a core dump labels Apr 21, 2019
    @berkerpeksag
    Copy link
    Member

    New changeset d59b662 by Berker Peksag (周家未) in branch 'master':
    bpo-36690: Fix typo in Tools/demo/rpython.py (GH-12903)
    d59b662

    @berkerpeksag
    Copy link
    Member

    New changeset 5407aaf by Berker Peksag (Miss Islington (bot)) in branch '3.7':
    bpo-36690: Fix typo in Tools/demo/rpython.py (GH-12903)
    5407aaf

    @berkerpeksag
    Copy link
    Member

    Thank you!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes easy type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant