Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suspicious.py sphinx extension access non-existing attribute. #81238

Closed
Carreau mannequin opened this issue May 26, 2019 · 3 comments
Closed

suspicious.py sphinx extension access non-existing attribute. #81238

Carreau mannequin opened this issue May 26, 2019 · 3 comments
Labels
3.8 only security fixes docs Documentation in the Doc dir

Comments

@Carreau
Copy link
Mannequin

Carreau mannequin commented May 26, 2019

BPO 37057
Nosy @Carreau
Superseder
  • bpo-36853: inconsistencies in docs builds (Sphinx 2)
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-05-26.17:37:55.503>
    created_at = <Date 2019-05-26.17:30:05.955>
    labels = ['3.8', 'docs']
    title = 'suspicious.py sphinx extension access non-existing attribute.'
    updated_at = <Date 2019-05-26.17:50:11.653>
    user = 'https://github.com/Carreau'

    bugs.python.org fields:

    activity = <Date 2019-05-26.17:50:11.653>
    actor = 'SilentGhost'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2019-05-26.17:37:55.503>
    closer = 'mbussonn'
    components = ['Documentation']
    creation = <Date 2019-05-26.17:30:05.955>
    creator = 'mbussonn'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 37057
    keywords = []
    message_count = 3.0
    messages = ['343569', '343571', '343572']
    nosy_count = 3.0
    nosy_names = ['SilentGhost', 'docs@python', 'mbussonn']
    pr_nums = []
    priority = 'normal'
    resolution = 'duplicate'
    stage = 'resolved'
    status = 'closed'
    superseder = '36853'
    type = None
    url = 'https://bugs.python.org/issue37057'
    versions = ['Python 3.8']

    @Carreau
    Copy link
    Mannequin Author

    Carreau mannequin commented May 26, 2019

    On a local branch with some modified docs

    Traceback (most recent call last):
      File "/Users/bussonniermatthias/dev/cpython/Doc/venv/lib/python3.8/site-packages/sphinx/cmd/build.py", line 284, in build_main
        app.build(args.force_all, filenames)
      File "/Users/bussonniermatthias/dev/cpython/Doc/venv/lib/python3.8/site-packages/sphinx/application.py", line 337, in build
        self.builder.build_update()
      File "/Users/bussonniermatthias/dev/cpython/Doc/venv/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 324, in build_update
        self.build(to_build,
      File "/Users/bussonniermatthias/dev/cpython/Doc/venv/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 392, in build
        self.finish()
      File "/Users/bussonniermatthias/dev/cpython/Doc/tools/extensions/suspicious.py", line 118, in finish
        self.warn('Found %s/%s unused rules:' %
    AttributeError: 'CheckSuspiciousMarkupBuilder' object has no attribute 'warn'
    

    My guess is that it should be self.logger.warn, and not self.warn.

    @Carreau Carreau mannequin added the 3.8 only security fixes label May 26, 2019
    @SilentGhost
    Copy link
    Mannequin

    SilentGhost mannequin commented May 26, 2019

    This looks like a duplicate of bpo-36853. Do you happen to have sphinx 2 installed?

    @SilentGhost SilentGhost mannequin added the docs Documentation in the Doc dir label May 26, 2019
    @SilentGhost SilentGhost mannequin assigned docspython May 26, 2019
    @Carreau
    Copy link
    Mannequin Author

    Carreau mannequin commented May 26, 2019

    Oh yeah, I do... and you are right this is duplicate.

    @Carreau Carreau mannequin closed this as completed May 26, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes docs Documentation in the Doc dir
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants