Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _PY_FASTCALL_SMALL_STACK for method_vectorcall #81414

Closed
jdemeyer opened this issue Jun 11, 2019 · 5 comments
Closed

Use _PY_FASTCALL_SMALL_STACK for method_vectorcall #81414

jdemeyer opened this issue Jun 11, 2019 · 5 comments
Labels
3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@jdemeyer
Copy link
Contributor

BPO 37233
Nosy @methane, @jdemeyer, @miss-islington
PRs
  • bpo-37233: use _PY_FASTCALL_SMALL_STACK in method_vectorcall #13974
  • bpo-37233: optimize case totalargs == 0 in method_vectorcall #14550
  • [3.8] bpo-37233: use _PY_FASTCALL_SMALL_STACK in method_vectorcall (GH-13974) #14573
  • [3.8] bpo-37233: optimize method_vectorcall in case of totalargs == 0 (GH-14550) #14574
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-06-18.13:41:51.025>
    created_at = <Date 2019-06-11.14:43:31.679>
    labels = ['interpreter-core', '3.9', 'performance']
    title = 'Use _PY_FASTCALL_SMALL_STACK for method_vectorcall'
    updated_at = <Date 2019-07-03.13:06:41.181>
    user = 'https://github.com/jdemeyer'

    bugs.python.org fields:

    activity = <Date 2019-07-03.13:06:41.181>
    actor = 'miss-islington'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-06-18.13:41:51.025>
    closer = 'jdemeyer'
    components = ['Interpreter Core']
    creation = <Date 2019-06-11.14:43:31.679>
    creator = 'jdemeyer'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 37233
    keywords = ['patch']
    message_count = 5.0
    messages = ['345234', '345968', '347218', '347227', '347229']
    nosy_count = 3.0
    nosy_names = ['methane', 'jdemeyer', 'miss-islington']
    pr_nums = ['13974', '14550', '14573', '14574']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'performance'
    url = 'https://bugs.python.org/issue37233'
    versions = ['Python 3.9']

    @jdemeyer
    Copy link
    Contributor Author

    The PEP-590 implementation for type "method" caused a minor regression: instead of using _PyObject_Call_Prepend(), method_vectorcall manually allocates and fills a newly allocated vector. This does NOT use the _PY_FASTCALL_SMALL_STACK optimization, but it should.

    @jdemeyer jdemeyer added 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage labels Jun 11, 2019
    @methane
    Copy link
    Member

    methane commented Jun 18, 2019

    New changeset 988e6aa by Inada Naoki (Jeroen Demeyer) in branch 'master':
    bpo-37233: use _PY_FASTCALL_SMALL_STACK in method_vectorcall (GH-13974)
    988e6aa

    @methane
    Copy link
    Member

    methane commented Jul 3, 2019

    New changeset 53c2143 by Inada Naoki (Jeroen Demeyer) in branch 'master':
    bpo-37233: optimize method_vectorcall in case of totalargs == 0 (GH-14550)
    53c2143

    @methane
    Copy link
    Member

    methane commented Jul 3, 2019

    New changeset c7570d4 by Inada Naoki in branch '3.8':
    [3.8] bpo-37233: use _PY_FASTCALL_SMALL_STACK in method_vectorcall (GH-13974)
    c7570d4

    @miss-islington
    Copy link
    Contributor

    New changeset 1099e34 by Miss Islington (bot) in branch '3.8':
    bpo-37233: optimize method_vectorcall in case of totalargs == 0 (GH-14550)
    1099e34

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants