Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test_complex for Windows arm64 #81417

Closed
paulmon mannequin opened this issue Jun 11, 2019 · 3 comments
Closed

fix test_complex for Windows arm64 #81417

paulmon mannequin opened this issue Jun 11, 2019 · 3 comments
Labels
3.8 only security fixes 3.9 only security fixes build The build process and cross-build OS-windows

Comments

@paulmon
Copy link
Mannequin

paulmon mannequin commented Jun 11, 2019

BPO 37236
Nosy @pfmoore, @mdickinson, @tjguk, @zware, @zooba, @miss-islington, @paulmon
PRs
  • bpo-37236: pragma optimize off for _Py_c_quot on Windows arm64 #13983
  • [3.8] bpo-37236: pragma optimize off for _Py_c_quot on Windows arm64 (GH-13983) #14024
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-06-27.20:37:15.665>
    created_at = <Date 2019-06-11.17:19:02.625>
    labels = ['build', '3.8', '3.9', 'OS-windows']
    title = 'fix test_complex for Windows arm64'
    updated_at = <Date 2019-06-27.20:37:15.664>
    user = 'https://github.com/paulmon'

    bugs.python.org fields:

    activity = <Date 2019-06-27.20:37:15.664>
    actor = 'Paul Monson'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-06-27.20:37:15.665>
    closer = 'Paul Monson'
    components = ['Windows']
    creation = <Date 2019-06-11.17:19:02.625>
    creator = 'Paul Monson'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 37236
    keywords = ['patch']
    message_count = 3.0
    messages = ['345254', '345396', '345400']
    nosy_count = 7.0
    nosy_names = ['paul.moore', 'mark.dickinson', 'tim.golden', 'zach.ware', 'steve.dower', 'miss-islington', 'Paul Monson']
    pr_nums = ['13983', '14024']
    priority = 'normal'
    resolution = None
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue37236'
    versions = ['Python 3.8', 'Python 3.9']

    @paulmon
    Copy link
    Mannequin Author

    paulmon mannequin commented Jun 11, 2019

    There is a compiler optimization error on Windows ARM64 that causes test_truediv (test.test_complex.ComplexTest) to fail with ZeroDivisionError: complex division by zero.

    Adding a pragma optimize around the affected function fixes the issue. I am also submitting a report to the compiler team

    @paulmon paulmon mannequin added 3.8 only security fixes 3.9 only security fixes OS-windows build The build process and cross-build labels Jun 11, 2019
    @zooba
    Copy link
    Member

    zooba commented Jun 12, 2019

    New changeset ff6bb0a by Steve Dower (Paul Monson) in branch 'master':
    bpo-37236: pragma optimize off for _Py_c_quot on Windows arm64 (GH-13983)
    ff6bb0a

    @miss-islington
    Copy link
    Contributor

    New changeset f72886a by Miss Islington (bot) in branch '3.8':
    bpo-37236: pragma optimize off for _Py_c_quot on Windows arm64 (GH-13983)
    f72886a

    @paulmon paulmon mannequin closed this as completed Jun 27, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes 3.9 only security fixes build The build process and cross-build OS-windows
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants